[M52] Cherry-pick e6c515f3d34096426b6822ad90a757131e8baf31

[M52] Cherry-pick e6c515f3d34096426b6822ad90a757131e8baf31

Fix int32 overflow in LinearGradientContext::shade4_dx_clamp

The unconditional increment in shade4_dx_clamp can overflow int32

=> n == SK_MinS32
=> count ~= SK_MinS32
=> we skip the main shader loop 'cause count < 0

Also include trivial 0e59bb7aaad272ac42d6fba53e8439bd9fa1ff3d followup
to ensure we're not tripping ASAN.

TBR=reed@google.com,mtklein@google.com
BUG=chromium:599458
Review-Url: https://codereview.chromium.org/2010843002
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true

Committed: https://skia.googlesource.com/skia/+/1fd666cbb9655e1ce5f37f435d1f9ea2d7b47827

[f(malita), 2016-05-28 13:53:17]

Description was changed from

==========
[M52] Cherry-pick e6c515f3d34096426b6822ad90a757131e8baf31

Also include trivial 0e59bb7aaad272ac42d6fba53e8439bd9fa1ff3d followup
to ensure we're not tripping ASAN.

Silence ASAN int32 overflow warning

It's fine to overflow SK_MaxS32 by one, the subsequent cast ensures
correct clamping.  But we need to cast earlier in order to make ASAN
happy.

TBR=mtklein@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2013243002

Review-Url: https://codereview.chromium.org/2013243002

Fix int32 overflow in LinearGradientContext::shade4_dx_clamp

The unconditional increment in shade4_dx_clamp can overflow int32

=> n == SK_MinS32
=> count ~= SK_MinS32
=> we skip the main shader loop 'cause count < 0

R=reed@google.com,mtklein@google.com
BUG=chromium:599458
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2010843002

Review-Url: https://codereview.chromium.org/2010843002
==========

to

==========
[M52] Cherry-pick e6c515f3d34096426b6822ad90a757131e8baf31

Also include trivial 0e59bb7aaad272ac42d6fba53e8439bd9fa1ff3d followup
to ensure we're not tripping ASAN.

Silence ASAN int32 overflow warning

It's fine to overflow SK_MaxS32 by one, the subsequent cast ensures
correct clamping.  But we need to cast earlier in order to make ASAN
happy.

TBR=mtklein@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2013243002

Review-Url: https://codereview.chromium.org/2013243002

Fix int32 overflow in LinearGradientContext::shade4_dx_clamp

The unconditional increment in shade4_dx_clamp can overflow int32

=> n == SK_MinS32
=> count ~= SK_MinS32
=> we skip the main shader loop 'cause count < 0

R=reed@google.com,mtklein@google.com
BUG=chromium:599458
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2010843002

Review-Url: https://codereview.chromium.org/2010843002
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
==========

[f(malita), 2016-05-28 13:55:34]

Description was changed from

==========
[M52] Cherry-pick e6c515f3d34096426b6822ad90a757131e8baf31

Also include trivial 0e59bb7aaad272ac42d6fba53e8439bd9fa1ff3d followup
to ensure we're not tripping ASAN.

Silence ASAN int32 overflow warning

It's fine to overflow SK_MaxS32 by one, the subsequent cast ensures
correct clamping.  But we need to cast earlier in order to make ASAN
happy.

TBR=mtklein@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2013243002

Review-Url: https://codereview.chromium.org/2013243002

Fix int32 overflow in LinearGradientContext::shade4_dx_clamp

The unconditional increment in shade4_dx_clamp can overflow int32

=> n == SK_MinS32
=> count ~= SK_MinS32
=> we skip the main shader loop 'cause count < 0

R=reed@google.com,mtklein@google.com
BUG=chromium:599458
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2010843002

Review-Url: https://codereview.chromium.org/2010843002
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
==========

to

==========
[M52] Cherry-pick e6c515f3d34096426b6822ad90a757131e8baf31

Fix int32 overflow in LinearGradientContext::shade4_dx_clamp

The unconditional increment in shade4_dx_clamp can overflow int32

=> n == SK_MinS32
=> count ~= SK_MinS32
=> we skip the main shader loop 'cause count < 0

Also include trivial 0e59bb7aaad272ac42d6fba53e8439bd9fa1ff3d followup
to ensure we're not tripping ASAN.

TBR=reed@google.com,mtklein@google.com
BUG=chromium:599458

Review-Url: https://codereview.chromium.org/2010843002
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
==========

[f(malita), 2016-05-28 13:57:23]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2016-05-28 13:57:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2021673002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2021673002/1

[commit-bot: I haz the power, 2016-05-28 13:57:41]

Description was changed from

==========
[M52] Cherry-pick e6c515f3d34096426b6822ad90a757131e8baf31

Fix int32 overflow in LinearGradientContext::shade4_dx_clamp

The unconditional increment in shade4_dx_clamp can overflow int32

=> n == SK_MinS32
=> count ~= SK_MinS32
=> we skip the main shader loop 'cause count < 0

Also include trivial 0e59bb7aaad272ac42d6fba53e8439bd9fa1ff3d followup
to ensure we're not tripping ASAN.

TBR=reed@google.com,mtklein@google.com
BUG=chromium:599458

Review-Url: https://codereview.chromium.org/2010843002
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
==========

to

==========
[M52] Cherry-pick e6c515f3d34096426b6822ad90a757131e8baf31

Fix int32 overflow in LinearGradientContext::shade4_dx_clamp

The unconditional increment in shade4_dx_clamp can overflow int32

=> n == SK_MinS32
=> count ~= SK_MinS32
=> we skip the main shader loop 'cause count < 0

Also include trivial 0e59bb7aaad272ac42d6fba53e8439bd9fa1ff3d followup
to ensure we're not tripping ASAN.

TBR=reed@google.com,mtklein@google.com
BUG=chromium:599458

Review-Url: https://codereview.chromium.org/2010843002
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true

Committed:
https://skia.googlesource.com/skia/+/1fd666cbb9655e1ce5f37f435d1f9ea2d7b47827
==========

[commit-bot: I haz the power, 2016-05-28 13:57:41]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1fd666cbb9655e1ce5f37f435d1f9ea2d7b47827