Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 2021643002: Record scores of distillability and long article in UMA (Closed)

Created:
4 years, 6 months ago by wychen
Modified:
4 years, 6 months ago
Reviewers:
mdjones, rkaplow
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, asvitkine+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@distillability-dev
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record scores of distillability and long article in UMA BUG=617769 Committed: https://crrev.com/9e7576cc96261045a9a72ab14a57e7204f09f415 Cr-Commit-Position: refs/heads/master@{#398483}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 4

Patch Set 3 : amend units #

Patch Set 4 : add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -2 lines) Patch
M components/dom_distiller/content/renderer/distillability_agent.cc View 1 2 3 1 chunk +28 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
wychen
PTAL
4 years, 6 months ago (2016-06-06 21:43:41 UTC) #2
rkaplow
https://codereview.chromium.org/2021643002/diff/20001/components/dom_distiller/content/renderer/distillability_agent.cc File components/dom_distiller/content/renderer/distillability_agent.cc (right): https://codereview.chromium.org/2021643002/diff/20001/components/dom_distiller/content/renderer/distillability_agent.cc#newcode111 components/dom_distiller/content/renderer/distillability_agent.cc:111: if (distillable) { this is confusing me, since the ...
4 years, 6 months ago (2016-06-07 20:51:12 UTC) #4
wychen
https://codereview.chromium.org/2021643002/diff/20001/components/dom_distiller/content/renderer/distillability_agent.cc File components/dom_distiller/content/renderer/distillability_agent.cc (right): https://codereview.chromium.org/2021643002/diff/20001/components/dom_distiller/content/renderer/distillability_agent.cc#newcode111 components/dom_distiller/content/renderer/distillability_agent.cc:111: if (distillable) { On 2016/06/07 20:51:12, rkaplow wrote: > ...
4 years, 6 months ago (2016-06-07 21:27:33 UTC) #5
rkaplow
On 2016/06/07 21:27:33, wychen wrote: > https://codereview.chromium.org/2021643002/diff/20001/components/dom_distiller/content/renderer/distillability_agent.cc > File components/dom_distiller/content/renderer/distillability_agent.cc (right): > > https://codereview.chromium.org/2021643002/diff/20001/components/dom_distiller/content/renderer/distillability_agent.cc#newcode111 > ...
4 years, 6 months ago (2016-06-07 21:37:27 UTC) #6
rkaplow
lgtm
4 years, 6 months ago (2016-06-07 21:37:32 UTC) #7
mdjones
lgtm
4 years, 6 months ago (2016-06-07 21:54:16 UTC) #8
wychen
On 2016/06/07 21:37:27, rkaplow wrote: > On 2016/06/07 21:27:33, wychen wrote: > > > https://codereview.chromium.org/2021643002/diff/20001/components/dom_distiller/content/renderer/distillability_agent.cc ...
4 years, 6 months ago (2016-06-07 22:12:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021643002/60001
4 years, 6 months ago (2016-06-08 03:35:10 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-08 04:48:25 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 04:49:28 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9e7576cc96261045a9a72ab14a57e7204f09f415
Cr-Commit-Position: refs/heads/master@{#398483}

Powered by Google App Engine
This is Rietveld 408576698