Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2021613002: Compare error names in strong_mode_test ignoring order. (Closed)

Created:
4 years, 6 months ago by scheglov
Modified:
4 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Compare error names in strong_mode_test ignoring order. These tests were flaky. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/9820588f065772d0462ab943a3db4e55644b29d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M pkg/analyzer/test/generated/strong_mode_test.dart View 3 chunks +17 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 6 months ago (2016-05-28 01:54:04 UTC) #1
Brian Wilkerson
lgtm
4 years, 6 months ago (2016-05-28 04:21:06 UTC) #2
scheglov
4 years, 6 months ago (2016-05-29 19:13:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9820588f065772d0462ab943a3db4e55644b29d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698