Make whitelist check per element

lib/src/compiler/code_generator.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:collection' show HashMap, HashSet;
 import 'dart:math' show min, max;
 
 import 'package:analyzer/analyzer.dart' hide ConstantEvaluator;
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart' show Token, TokenType;
@@ skipping 108 matching lines @@
   /// Helper class for emitting elements in the proper order to allow
   /// JS to load the module.
   ElementLoader _loader;
 
   BuildUnit _buildUnit;
 
   String _buildRoot;
 
   bool _superAllowed = true;
 
-  bool _inAngularTemplate = false;
-
   List<JS.TemporaryId> _superHelperSymbols = <JS.TemporaryId>[];
   List<JS.Method> _superHelpers = <JS.Method>[];
 
   List<TypeParameterType> _typeParamInConst = null;
 
   /// Whether we are currently generating code for the body of a `JS()` call.
   bool _isInForeignJS = false;
 
   CodeGenerator(AnalysisContext c, this.options, this._extensionTypes)
       : context = c,
@@ skipping 278 matching lines @@
 
     if (item != null) _moduleItems.add(item);
   }
 
   void _declareBeforeUse(Element e) {
     _loader.declareBeforeUse(e, _emitDeclaration);
   }
 
   @override
   void visitCompilationUnit(CompilationUnit unit) {
-    _inAngularTemplate =
-        unit.element.source.fullName.endsWith(".template.dart");
-
     _constField = new ConstFieldVisitor(types, unit.element.source);
 
     for (var declaration in unit.declarations) {
       var element = declaration.element;
       if (element != null) {
         _emitDeclaration(element);
       } else {
         declaration.accept(this);
       }
     }
     for (var directive in unit.directives) {
       directive.accept(this);
     }
-    _inAngularTemplate = false;
   }
 
   @override
   void visitLibraryDirective(LibraryDirective node) {}
 
   @override
   void visitImportDirective(ImportDirective node) {
     // We don't handle imports here.
     //
     // Instead, we collect imports whenever we need to generate a reference
@@ skipping 85 matching lines @@
         return js.call('dart.asInt(#)', jsFrom);
       }
 
       // A no-op in JavaScript.
       return jsFrom;
     }
 
     var type = _emitType(to,
         nameType: options.nameTypeTests || options.hoistTypeTests,
         hoistType: options.hoistTypeTests);
-    if (_inAngularTemplate) return jsFrom;
+    if (_inWhitelistCode(node)) return jsFrom;
     if (isReifiedCoercion(node)) {
       return js.call('dart.check(#, #)', [jsFrom, type]);
     } else {
       return js.call('dart.as(#, #)', [jsFrom, type]);
     }
   }
 
   bool isReifiedCoercion(AstNode node) {
     // TODO(sra): Find a better way to recognize reified coercion, since we
     // can't set the isSynthetic attribute.
@@ skipping 1168 matching lines @@
         }
       }
 
       // TODO(jmesserly): various problems here, see:
       // https://github.com/dart-lang/dev_compiler/issues/116
       var paramType = param.element.type;
       if (node is MethodDeclaration && _unsoundCovariant(paramType, true)) {
         var castType = _emitType(paramType,
             nameType: options.nameTypeTests || options.hoistTypeTests,
             hoistType: options.hoistTypeTests);
-        if (!_inAngularTemplate) {
+        if (!_inWhitelistCode(node)) {
           body.add(js.statement('dart.as(#, #);', [jsParam, castType]));
         }
       }
     }
     return body.isEmpty ? null : _statement(body);
   }
 
   /// Given a type [t], return whether or not t is unsoundly covariant.
   /// If [contravariant] is true, then t appears in a contravariant
   /// position.
@@ skipping 779 matching lines @@
       }
 
       target = _getTarget(lhs);
       id = lhs.propertyName;
     } else if (lhs is PrefixedIdentifier) {
       target = lhs.prefix;
       id = lhs.identifier;
     }
 
     if (target != null && DynamicInvoke.get(target)) {
-      if (_inAngularTemplate) {
+      if (_inWhitelistCode(lhs)) {
         return _visit(rhs).toAssignExpression(_visit(lhs));
       }
       return js.call('dart.dput(#, #, #)',
           [_visit(target), _emitMemberName(id.name), _visit(rhs)]);
     }
 
     return _visit(rhs).toAssignExpression(_visit(lhs));
   }
 
   JS.Expression _emitNullSafeSet(PropertyAccess node, Expression right) {
@@ skipping 112 matching lines @@
       List<JS.Expression> args,
       List<JS.Expression> typeArgs) {
     var type = getStaticType(target);
     var name = node.methodName.name;
     var element = node.methodName.staticElement;
     bool isStatic = element is ExecutableElement && element.isStatic;
     var memberName = _emitMemberName(name, type: type, isStatic: isStatic);
 
     JS.Expression jsTarget = _visit(target);
     if (DynamicInvoke.get(target) || DynamicInvoke.get(node.methodName)) {
-      if (_inAngularTemplate) {
+      if (_inWhitelistCode(target)) {
         jsTarget = new JS.PropertyAccess(jsTarget, memberName);
         if (typeArgs != null) jsTarget = new JS.Call(jsTarget, typeArgs);
         return new JS.Call(jsTarget, args);
       }
       if (typeArgs != null) {
         return js.call('dart.dgsend(#, #, #, #)',
             [jsTarget, new JS.ArrayInitializer(typeArgs), memberName, args]);
       } else {
         return js.call('dart.dsend(#, #, #)', [jsTarget, memberName, args]);
       }
@@ skipping 13 matching lines @@
   /// an expression.
   JS.Expression _emitFunctionCall(InvocationExpression node) {
     var fn = _visit(node.function);
     var args = _visit(node.argumentList) as List<JS.Expression>;
     if (DynamicInvoke.get(node.function)) {
       var typeArgs = _emitInvokeTypeArguments(node);
       if (typeArgs != null) {
         return js.call('dart.dgcall(#, #, #)',
             [fn, new JS.ArrayInitializer(typeArgs), args]);
       } else {
-        if (_inAngularTemplate) {
+        if (_inWhitelistCode(node)) {
           return new JS.Call(fn, args);
         }
         return js.call('dart.dcall(#, #)', [fn, args]);
       }
     } else {
       return new JS.Call(_applyInvokeTypeArguments(fn, node), args);
     }
   }
 
   JS.Expression _applyInvokeTypeArguments(
@@ skipping 1160 matching lines @@
     if (type == null) return null;
     return _emitFunctionTypeArguments(type, instantiated);
   }
 
   JS.Expression _emitAccessInternal(Expression target, Element member,
       String memberName, List<JS.Expression> typeArgs) {
     bool isStatic = member is ClassMemberElement && member.isStatic;
     var name = _emitMemberName(memberName,
         type: getStaticType(target), isStatic: isStatic);
     if (DynamicInvoke.get(target)) {
-      if (_inAngularTemplate) {
+      if (_inWhitelistCode(target)) {
         return js.call('#.#', [_visit(target), name]);
       }
       return js.call('dart.dload(#, #)', [_visit(target), name]);
     }
 
     var jsTarget = _visit(target);
     bool isSuper = jsTarget is JS.Super;
 
     if (isSuper && member is FieldElement && !member.isSynthetic) {
       // If super.x is actually a field, then x is an instance property since
@@ skipping 32 matching lines @@
       Expression target, String name, List<Expression> args) {
     var type = getStaticType(target);
     var memberName = _emitMemberName(name, unary: args.isEmpty, type: type);
     if (DynamicInvoke.get(target)) {
       // dynamic dispatch
       var dynamicHelper = const {'[]': 'dindex', '[]=': 'dsetindex'}[name];
       if (dynamicHelper != null) {
         return js.call(
             'dart.$dynamicHelper(#, #)', [_visit(target), _visitList(args)]);
       }
-      if (_inAngularTemplate) {
+      if (_inWhitelistCode(target)) {
         return js
             .call('#.#(#)', [_visit(target), memberName, _visitList(args)]);
       } else {
         return js.call('dart.dsend(#, #, #)',
             [_visit(target), memberName, _visitList(args)]);
       }
     }
 
     // Generic dispatch to a statically known method.
     return js.call('#.#(#)', [_visit(target), memberName, _visitList(args)]);
@@ skipping 661 matching lines @@
     if (type.isDynamic) {
       return type;
     } else if (type is InterfaceType && type.element == expectedType.element) {
       return type.typeArguments[0];
     } else {
       // TODO(leafp): The above only handles the case where the return type
       // is exactly Future/Stream/Iterable.  Handle the subtype case.
       return DynamicTypeImpl.instance;
     }
   }
+
+  /// Maps whitelisted files to a list of whitelisted methods
+  /// within the file.
+  ///
+  /// If the value is null, the entire file is whitelisted.
+  static Map<String, List<String>> _uncheckedWhitelist = {};
+
+  bool _inWhitelistCode(AstNode node) {
+    if (!options.useUncheckedWhitelist) return false;
+    var path = _loader.currentElement.source.fullName;
+    var filename = path.split("/").last;
+    if (_uncheckedWhitelist.containsKey(filename)) {
+      var whitelisted = _uncheckedWhitelist[filename];
+      if (whitelisted == null) return true;
+      var enclosing = node;
+      while (enclosing != null &&
+          !(enclosing is ClassMember || enclosing is FunctionDeclaration)) {
+        enclosing = enclosing.parent;
+      }
+      String name = (enclosing as dynamic)?.element?.name;
+      if (name != null) {
+        return whitelisted.contains(name);
+      }
+    }
+    return path.endsWith(".template.dart");
+  }
 }
 
 /// Choose a canonical name from the library element.
 /// This never uses the library's name (the identifier in the `library`
 /// declaration) as it doesn't have any meaningful rules enforced.
 String jsLibraryName(String buildRoot, LibraryElement library) {
   var uri = library.source.uri;
   if (uri.scheme == 'dart') {
     return uri.path;
   }
@@ skipping 39 matching lines @@
 }
 
 bool isLibraryPrefix(Expression node) =>
     node is SimpleIdentifier && node.staticElement is PrefixElement;
 
 LibraryElement _getLibrary(AnalysisContext c, String uri) =>
     c.computeLibraryElement(c.sourceFactory.forUri(uri));
 
 bool _isDartRuntime(LibraryElement l) =>
     l.isInSdk && l.source.uri.toString() == 'dart:_runtime';