Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2021553002: Make whitelist check per element (Closed)

Created:
4 years, 6 months ago by Leaf
Modified:
4 years, 6 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -16 lines) Patch
M lib/src/compiler/code_generator.dart View 1 2 11 chunks +33 lines, -13 lines 0 comments Download
M lib/src/compiler/compiler.dart View 1 2 4 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Leaf
4 years, 6 months ago (2016-06-01 18:31:35 UTC) #2
vsm
lgtm https://codereview.chromium.org/2021553002/diff/20001/lib/src/compiler/compiler.dart File lib/src/compiler/compiler.dart (right): https://codereview.chromium.org/2021553002/diff/20001/lib/src/compiler/compiler.dart#newcode263 lib/src/compiler/compiler.dart:263: ..addFlag('use-unchecked-whitelist', defaultsTo: false, hide: true); How about 'unsafe-angular2-whitelist' ...
4 years, 6 months ago (2016-06-01 19:02:14 UTC) #3
Leaf
https://codereview.chromium.org/2021553002/diff/20001/lib/src/compiler/compiler.dart File lib/src/compiler/compiler.dart (right): https://codereview.chromium.org/2021553002/diff/20001/lib/src/compiler/compiler.dart#newcode263 lib/src/compiler/compiler.dart:263: ..addFlag('use-unchecked-whitelist', defaultsTo: false, hide: true); On 2016/06/01 19:02:14, vsm ...
4 years, 6 months ago (2016-06-01 20:04:05 UTC) #4
Leaf
4 years, 6 months ago (2016-06-01 20:12:46 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
7f68e5ef424dd26344572daf02595ab23fb16941 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698