Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 2021543002: [MD Feedback] Add basic chrome://feedback WebUI. (Closed)

Created:
4 years, 6 months ago by apacible
Modified:
4 years, 6 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, apacible+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Feedback] Add basic chrome://feedback WebUI. This change: - Adds chrome://feedback/ URL and feedback host. - Opens a placeholder page when chrome://feedback/ is hit. In the future, chrome://feedback will open in a WebUI dialog. BUG=615533 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b8137c423af74ecb9b1def3b09b5e6efbb32856a Cr-Commit-Position: refs/heads/master@{#396985}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -1 line) Patch
M chrome/browser/browser_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
A + chrome/browser/resources/md_feedback/feedback.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 3 chunks +8 lines, -1 line 0 comments Download
A chrome/browser/ui/webui/md_feedback/md_feedback_ui.h View 1 chunk +20 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/url_constants.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
apacible
PTAL, thanks!
4 years, 6 months ago (2016-05-27 22:07:09 UTC) #5
apacible
WebUI resources will be properly implemented after the initial setup work (crbug/615535). I prefer smaller ...
4 years, 6 months ago (2016-05-27 22:08:31 UTC) #6
Dan Beam
lgtm
4 years, 6 months ago (2016-05-31 21:35:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021543002/20001
4 years, 6 months ago (2016-05-31 22:01:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-01 00:04:59 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 00:06:19 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8137c423af74ecb9b1def3b09b5e6efbb32856a
Cr-Commit-Position: refs/heads/master@{#396985}

Powered by Google App Engine
This is Rietveld 408576698