Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2021533003: Specify --test-machine-name to maps_pixel_test running on bots. (Closed)

Created:
4 years, 6 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 6 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, cblume
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Specify --test-machine-name to maps_pixel_test running on bots. Neglected to verify that this was specified for maps_pixel_test rather than pixel_test. This caused the new test to fail on all of the Android bots rather than only two of them as originally planned. BUG=611932 TBR=zmo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/8c195d7f3e42d49026f18cc15423f60fa428d710 Cr-Commit-Position: refs/heads/master@{#396604}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -43 lines) Patch
M content/test/gpu/generate_buildbot_json.py View 1 chunk +8 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/cloud_storage_test_base.py View 1 chunk +4 lines, -1 line 0 comments Download
M content/test/gpu/page_sets/data/maps_004_expectations.json View 1 chunk +2 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.gpu.json View 9 chunks +63 lines, -9 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 31 chunks +217 lines, -31 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Ken Russell (switch to Gerrit)
FYI. CQ'ing TBR'd.
4 years, 6 months ago (2016-05-27 22:13:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021533003/1
4 years, 6 months ago (2016-05-27 22:13:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 23:56:20 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 23:57:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c195d7f3e42d49026f18cc15423f60fa428d710
Cr-Commit-Position: refs/heads/master@{#396604}

Powered by Google App Engine
This is Rietveld 408576698