Source/core/page/DragController.cpp - Issue 202153005: Add isHTMLPlugInElement() helpers for consistency with other HTML elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/DragController.cpp

Issue 202153005: Add isHTMLPlugInElement() helpers for consistency with other HTML elements (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Keep virtual function Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/DragController.cpp

diff --git a/Source/core/page/DragController.cpp b/Source/core/page/DragController.cpp

index a254211cf33917a69efd88df602c50bf21a1518a..c2456604ab9eb888d8fd9ebf1f8d5f0d7589d93e 100644

--- a/Source/core/page/DragController.cpp

+++ b/Source/core/page/DragController.cpp

@@ -554,7 +554,7 @@ bool DragController::canProcessDrag(DragData* dragData)

if (dragData->containsFiles() && asFileInput(result.innerNonSharedNode()))

return true;

- if (result.innerNonSharedNode()->isPluginElement()) {

+ if (isHTMLPlugInElement(*result.innerNonSharedNode())) {

HTMLPlugInElement* plugin = toHTMLPlugInElement(result.innerNonSharedNode());

if (!plugin->canProcessDrag() && !result.innerNonSharedNode()->rendererIsEditable())

return false;