Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 2021483002: mus: Remove ViewportMetrics from mojom. (Closed)

Created:
4 years, 6 months ago by sadrul
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez, sky
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: Remove ViewportMetrics from mojom. ViewportMetrics is no longer sent over IPC to the clients, so remove it from the mojom. Also, simplify the usage a bit, for example, rename 'device pixel ratio' to 'device scale factor', since that's what the rest of the code (in //ui/display and elsewhere) calls it. Also, remove GetViewportMetrics() from PlatformDisplay and Display, and introduce GetDeviceScaleFactor() on PlatformDisplay, since that was the only use for it. BUG=603316 Committed: https://crrev.com/21c4cdea43a46afbfec9b66455d7cbc35c0f041b Cr-Commit-Position: refs/heads/master@{#396534}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -81 lines) Patch
M components/mus/public/interfaces/window_tree.mojom View 1 chunk +0 lines, -6 lines 0 comments Download
M components/mus/ws/display.h View 2 chunks +2 lines, -6 lines 0 comments Download
M components/mus/ws/display.cc View 3 chunks +5 lines, -11 lines 0 comments Download
M components/mus/ws/platform_display.h View 1 6 chunks +10 lines, -5 lines 0 comments Download
M components/mus/ws/platform_display.cc View 7 chunks +16 lines, -21 lines 0 comments Download
M components/mus/ws/platform_display_delegate.h View 3 chunks +3 lines, -4 lines 0 comments Download
M components/mus/ws/test_utils.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M components/mus/ws/window_server.h View 1 chunk +0 lines, -5 lines 0 comments Download
M components/mus/ws/window_server.cc View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
sadrul
tsepez@ for change in window_tree.mojom sky@ for everything
4 years, 6 months ago (2016-05-27 16:33:32 UTC) #2
sky
LGTM
4 years, 6 months ago (2016-05-27 16:46:08 UTC) #3
Tom Sepez
lgtm
4 years, 6 months ago (2016-05-27 16:47:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021483002/1
4 years, 6 months ago (2016-05-27 17:05:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/155260)
4 years, 6 months ago (2016-05-27 17:18:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021483002/20001
4 years, 6 months ago (2016-05-27 18:18:24 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-27 19:36:37 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 19:38:05 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/21c4cdea43a46afbfec9b66455d7cbc35c0f041b
Cr-Commit-Position: refs/heads/master@{#396534}

Powered by Google App Engine
This is Rietveld 408576698