Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: components/cronet/android/BUILD.gn

Issue 2021433004: Cert - protobufs to serialize and deserialize CertVerifierCache. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Add_support_for_walking_1999733002
Patch Set: Fix comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/BUILD.gn
diff --git a/components/cronet/android/BUILD.gn b/components/cronet/android/BUILD.gn
index b0081287c36d8763dcff781da3be9c0c1c612838..58c678eb377f8b422ca19296725fd42d0d187c1f 100644
--- a/components/cronet/android/BUILD.gn
+++ b/components/cronet/android/BUILD.gn
@@ -8,6 +8,7 @@ import("//build/config/android/rules.gni")
import("//build/util/version.gni")
import("//chrome/version.gni")
import("//testing/test.gni")
+import("//third_party/protobuf/proto_library.gni")
import("//url/features.gni")
assert(!is_component_build, "Cronet requires static library build.")
@@ -105,6 +106,20 @@ process_version("cronet_version_header") {
]
}
+proto_library("cronet_cert_proto") {
+ visibility = [ "//components/cronet/android/*" ]
+
+ sources = [
+ "//components/cronet/cert/proto/cert_verification.proto",
+ ]
+
+ deps = [
+ "//third_party/protobuf:protobuf_lite",
+ ]
+
+ extra_configs = [ "//build/config/compiler:wexit_time_destructors" ]
+}
+
# Variables:
# defines: Extra defines.
# deps: Extra dependencies.
@@ -114,6 +129,7 @@ template("cronet_static_tmpl") {
deps = [
":chromium_url_request_java",
+ ":cronet_cert_proto",
mef 2016/06/24 19:16:20 How much does it increase the binary size?
ramant (doing other things) 2016/06/24 23:28:01 In Debug build, cronet.so size has increased from
":cronet_jni_headers",
":cronet_version_header",
"//base",
@@ -151,6 +167,8 @@ template("cronet_static_tmpl") {
"//components/cronet/android/url_request_error.h",
"//components/cronet/android/wrapped_channel_upload_element_reader.cc",
"//components/cronet/android/wrapped_channel_upload_element_reader.h",
+ "//components/cronet/cert/cert_verifier_cache_serializer.cc",
+ "//components/cronet/cert/cert_verifier_cache_serializer.h",
"//components/cronet/histogram_manager.cc",
"//components/cronet/histogram_manager.h",
"//components/cronet/url_request_context_config.cc",
@@ -671,17 +689,20 @@ android_apk("cronet_perf_test_apk") {
test("cronet_unittests") {
sources = [
+ "//components/cronet/cert/cert_verifier_cache_serializer_unittest.cc",
"//components/cronet/histogram_manager_unittest.cc",
"//components/cronet/run_all_unittests.cc",
"//components/cronet/url_request_context_config_unittest.cc",
]
deps = [
+ ":cronet_cert_proto",
":cronet_static",
"//base",
"//base/test:test_support",
"//components/metrics",
"//net",
+ "//net:test_support",
"//testing/gtest",
]

Powered by Google App Engine
This is Rietveld 408576698