Cert - protobufs to serialize and deserialize CertVerifierCache.

net/cert/cert_verify_result.cc

Index: net/cert/cert_verify_result.cc
diff --git a/net/cert/cert_verify_result.cc b/net/cert/cert_verify_result.cc
index 7a1082e9f44162efb747b988f8fe7f0d593c4e3a..0a8a18ae12020cb124617bba284f3a12f84d697e 100644
--- a/net/cert/cert_verify_result.cc
+++ b/net/cert/cert_verify_result.cc
@@ -32,4 +32,16 @@ void CertVerifyResult::Reset() {
   public_key_hashes.clear();
 }
 
+bool CertVerifyResult::operator==(const CertVerifyResult& other) const {
+  return verified_cert->Equals(other.verified_cert.get()) &&
+         cert_status == other.cert_status && has_md2 == other.has_md2 &&
+         has_md4 == other.has_md4 && has_md5 == other.has_md5 &&
+         has_sha1 == other.has_sha1 && has_sha1_leaf == other.has_sha1_leaf &&
+         public_key_hashes == other.public_key_hashes &&
+         is_issued_by_known_root == other.is_issued_by_known_root &&
+         is_issued_by_additional_trust_anchor ==
+             other.is_issued_by_additional_trust_anchor &&
+         common_name_fallback_used == other.common_name_fallback_used;

[Ryan Sleevi, 2016/06/22 22:32:20]

Could also do:

return verified_cert->Equals(other.verified_cert.get()) &&
  std::tie(cert_status, has_md2, has_md4, has_md5, has_sha1, public_key_hashes,
is_issued_by_known_root, is_issued_by_additional_trust_anchor,
common_name_fallback_used) ==
  std::tie(other.cert_status, other.has_md2, other.has_md4, other.has_md5,
other.has_sha1, other.public_key_hashes, other.is_issued_by_known_root,
other.is_issued_by_additional_trust_anchor, other.common_name_fallback_used)


Avoids a lot of the repetitive &&/==

[ramant (doing other things), 2016/06/22 23:25:22]

Done.

+}
+
 }  // namespace net