Cert - protobufs to serialize and deserialize CertVerifierCache.

components/cronet/android/BUILD.gn

Index: components/cronet/android/BUILD.gn
diff --git a/components/cronet/android/BUILD.gn b/components/cronet/android/BUILD.gn
index 48b91046012f32cc836c44a5f4da01d75150ab00..2358623dccb8135822e6285c3ffb7ebb19588432 100644
--- a/components/cronet/android/BUILD.gn
+++ b/components/cronet/android/BUILD.gn
@@ -8,6 +8,7 @@ import("//build/config/android/rules.gni")
 import("//build/util/version.gni")
 import("//chrome/version.gni")
 import("//testing/test.gni")
+import("//third_party/protobuf/proto_library.gni")
 import("//url/features.gni")
 
 assert(!is_component_build, "Cronet requires static library build.")
@@ -105,6 +106,14 @@ process_version("cronet_version_header") {
   ]
 }
 
+proto_library("cronet_cert_proto") {

[Ryan Sleevi, 2016/06/15 23:31:31]

Can you restrict the visibility to the template? Is that something GN allows?

The context is making sure we don't end up with J-Random-User depending on this
target, since it's really an implementation detail (AFAICT)

[ramant (doing other things), 2016/06/17 02:45:14]

Done.

+  sources = [
+    "//components/cronet/cert/proto/cert_verification.proto",
+  ]
+
+  extra_configs = [ "//build/config/compiler:wexit_time_destructors" ]
+}
+
 # Variables:
 #   defines: Extra defines.
 #   deps: Extra dependencies.
@@ -114,6 +123,7 @@ template("cronet_static_tmpl") {
 
     deps = [
       ":chromium_url_request_java",
+      ":cronet_cert_proto",
       ":cronet_jni_headers",
       ":cronet_version_header",
       "//base",
@@ -121,6 +131,7 @@ template("cronet_static_tmpl") {
       "//base/third_party/dynamic_annotations",
       "//components/metrics",
       "//components/prefs",
+      "//third_party/protobuf:protobuf_lite",

[Ryan Sleevi, 2016/06/15 23:31:31]

Doesn't the proto_library take on that dep, rather than the target itself?

[ramant (doing other things), 2016/06/17 02:45:14]

Done.

       "//url:url_features",
     ]
     sources = [
@@ -152,6 +163,8 @@ template("cronet_static_tmpl") {
       "//components/cronet/android/url_request_error.h",
       "//components/cronet/android/wrapped_channel_upload_element_reader.cc",
       "//components/cronet/android/wrapped_channel_upload_element_reader.h",
+      "//components/cronet/cert/cert_verifier_cache_persister.cc",
+      "//components/cronet/cert/cert_verifier_cache_persister.h",
       "//components/cronet/histogram_manager.cc",
       "//components/cronet/histogram_manager.h",
       "//components/cronet/url_request_context_config.cc",
@@ -669,6 +682,7 @@ android_apk("cronet_perf_test_apk") {
 
 test("cronet_unittests") {
   sources = [
+    "//components/cronet/cert/cert_verifier_cache_persister_unittest.cc",
     "//components/cronet/histogram_manager_unittest.cc",
     "//components/cronet/run_all_unittests.cc",
     "//components/cronet/url_request_context_config_unittest.cc",
@@ -680,6 +694,7 @@ test("cronet_unittests") {
     "//base/test:test_support",
     "//components/metrics",
     "//net",
+    "//net:test_support",
     "//testing/gtest",
   ]