Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2021433003: [turbofan] Add a CHECK for max node input count (Closed)

Created:
4 years, 6 months ago by Jakob Kummerow
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, Jarin
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add a CHECK for max node input count This is a temporary band-aid to turn an uncontrolled segfault into a safe crash. The proper fix will probably be to abort compilation. BUG=chromium:582702 Committed: https://crrev.com/4892cd636248ae0590a7cc1502159e7a3e222283 Cr-Commit-Position: refs/heads/master@{#36554}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/compiler/instruction.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Jakob Kummerow
As discussed. PTAL.
4 years, 6 months ago (2016-05-27 16:30:17 UTC) #2
Benedikt Meurer
LGTM, thanks for doing the quick fix.
4 years, 6 months ago (2016-05-27 17:22:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021433003/1
4 years, 6 months ago (2016-05-27 17:32:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 17:56:18 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 17:59:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4892cd636248ae0590a7cc1502159e7a3e222283
Cr-Commit-Position: refs/heads/master@{#36554}

Powered by Google App Engine
This is Rietveld 408576698