|
Reland of land: Forward output glitch information from stream WebRTC log (patchset #1 id:1 of https://codereview.chromium.org/2028053002/ )
Reason for revert:
The WebRTC Linux Tests bot is still broken after the revert, so relanding.
Original issue's description:
> Revert of Reland: Forward output glitch information from stream WebRTC log (patchset #3 id:60001 of https://codereview.chromium.org/2022023002/ )
>
> Reason for revert:
> This is a speculative revert, as this CL is suspect of breaking the WebRTC Linux Tester bot.
>
> See: https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/17602
>
> If the revert doesn't work, I'll reland.
>
> Original issue's description:
> > Forward output glitch information from stream WebRTC log
> >
> > * A callback is added as input parameter on AudioManager create stream functions.
> > * OnLogMessage() function is added to the AudioLog interface.
> > * The AudioOutputDispatcherImpl gives AudioLog::OnLogMessage() as callback when creating an output stream.
> > * AudioInputController gives AudioInputController::LogMessage() (new function) as callback when creating an input stream. In this function, the message is passed to AudioInputRendererHost::OnLog().
> > * In both input and output cases, the message is then passed to the WebRTC log.
> > * The Mac input and output streams inform about OS glitches via the callback.
> >
> > This relands https://codereview.chromium.org/1864483002
> >
> > BUG= 610967
> > TBR=slan@chromium.org,sievers@chromium.org,xiyuan@chromium.org (for unchanged files from original CL)
> >
> > Committed: https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d
> > Cr-Commit-Position: refs/heads/master@{#396818}
>
> TBR=tommi@chromium.org,slan@chromium.org,sievers@chromium.org,xiyuan@chromium.org,grunell@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG= 610967
> NOPRESUBMIT=true
>
> Committed: https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872
> Cr-Commit-Position: refs/heads/master@{#397145}
TBR=tommi@chromium.org,slan@chromium.org,sievers@chromium.org,xiyuan@chromium.org,grunell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 610967
Committed: https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7
Cr-Commit-Position: refs/heads/master@{#397166}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+420 lines, -212 lines) |
Patch |
 |
M |
chromecast/media/audio/cast_audio_manager.h
|
View
|
|
1 chunk |
+8 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chromecast/media/audio/cast_audio_manager.cc
|
View
|
|
1 chunk |
+8 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chromecast/media/audio/cast_audio_output_stream_unittest.cc
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
components/audio_modem/audio_recorder_impl.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/media/media_internals.cc
|
View
|
|
3 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/media/video_capture_manager.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
media/audio/alsa/alsa_output_unittest.cc
|
View
|
|
1 chunk |
+11 lines, -7 lines |
0 comments
|
Download
|
 |
M |
media/audio/alsa/audio_manager_alsa.h
|
View
|
|
1 chunk |
+8 lines, -4 lines |
0 comments
|
Download
|
 |
M |
media/audio/alsa/audio_manager_alsa.cc
|
View
|
|
1 chunk |
+10 lines, -4 lines |
0 comments
|
Download
|
 |
M |
media/audio/android/audio_android_unittest.cc
|
View
|
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
media/audio/android/audio_manager_android.h
|
View
|
|
1 chunk |
+14 lines, -7 lines |
0 comments
|
Download
|
 |
M |
media/audio/android/audio_manager_android.cc
|
View
|
|
5 chunks |
+20 lines, -11 lines |
0 comments
|
Download
|
 |
M |
media/audio/audio_input_controller.h
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
media/audio/audio_input_controller.cc
|
View
|
|
11 chunks |
+20 lines, -14 lines |
0 comments
|
Download
|
 |
M |
media/audio/audio_input_unittest.cc
|
View
|
|
2 chunks |
+4 lines, -1 line |
0 comments
|
Download
|
 |
M |
media/audio/audio_logging.h
|
View
|
|
2 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
media/audio/audio_low_latency_input_output_unittest.cc
|
View
|
|
4 chunks |
+7 lines, -2 lines |
0 comments
|
Download
|
 |
M |
media/audio/audio_manager.h
|
View
|
|
4 chunks |
+9 lines, -2 lines |
0 comments
|
Download
|
 |
M |
media/audio/audio_manager_base.h
|
View
|
|
2 chunks |
+16 lines, -7 lines |
0 comments
|
Download
|
 |
M |
media/audio/audio_manager_base.cc
|
View
|
|
4 chunks |
+8 lines, -6 lines |
0 comments
|
Download
|
 |
M |
media/audio/audio_output_dispatcher_impl.cc
|
View
|
|
2 chunks |
+5 lines, -2 lines |
0 comments
|
Download
|
 |
M |
media/audio/audio_output_proxy_unittest.cc
|
View
|
|
20 chunks |
+52 lines, -37 lines |
0 comments
|
Download
|
 |
M |
media/audio/cras/audio_manager_cras.h
|
View
|
|
1 chunk |
+8 lines, -4 lines |
0 comments
|
Download
|
 |
M |
media/audio/cras/audio_manager_cras.cc
|
View
|
|
2 chunks |
+10 lines, -4 lines |
0 comments
|
Download
|
 |
M |
media/audio/fake_audio_log_factory.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
media/audio/fake_audio_manager.h
|
View
|
|
1 chunk |
+8 lines, -4 lines |
0 comments
|
Download
|
 |
M |
media/audio/fake_audio_manager.cc
|
View
|
|
1 chunk |
+8 lines, -4 lines |
0 comments
|
Download
|
 |
M |
media/audio/mac/audio_auhal_mac.h
|
View
|
|
3 chunks |
+6 lines, -1 line |
0 comments
|
Download
|
 |
M |
media/audio/mac/audio_auhal_mac.cc
|
View
|
|
4 chunks |
+13 lines, -6 lines |
0 comments
|
Download
|
 |
M |
media/audio/mac/audio_auhal_mac_unittest.cc
|
View
|
|
4 chunks |
+19 lines, -5 lines |
0 comments
|
Download
|
 |
M |
media/audio/mac/audio_low_latency_input_mac.h
|
View
|
|
3 chunks |
+6 lines, -1 line |
0 comments
|
Download
|
 |
M |
media/audio/mac/audio_low_latency_input_mac.cc
|
View
|
|
5 chunks |
+15 lines, -7 lines |
0 comments
|
Download
|
 |
M |
media/audio/mac/audio_low_latency_input_mac_unittest.cc
|
View
|
|
4 chunks |
+11 lines, -2 lines |
0 comments
|
Download
|
 |
M |
media/audio/mac/audio_manager_mac.h
|
View
|
|
1 chunk |
+8 lines, -4 lines |
0 comments
|
Download
|
 |
M |
media/audio/mac/audio_manager_mac.cc
|
View
|
|
5 chunks |
+15 lines, -8 lines |
0 comments
|
Download
|
 |
M |
media/audio/mock_audio_manager.h
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
media/audio/mock_audio_manager.cc
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
media/audio/pulse/audio_manager_pulse.h
|
View
|
|
1 chunk |
+8 lines, -4 lines |
0 comments
|
Download
|
 |
M |
media/audio/pulse/audio_manager_pulse.cc
|
View
|
|
2 chunks |
+10 lines, -4 lines |
0 comments
|
Download
|
 |
M |
media/audio/win/audio_low_latency_input_win_unittest.cc
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
media/audio/win/audio_low_latency_output_win_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
media/audio/win/audio_manager_win.h
|
View
|
|
1 chunk |
+8 lines, -4 lines |
0 comments
|
Download
|
 |
M |
media/audio/win/audio_manager_win.cc
|
View
|
|
4 chunks |
+10 lines, -4 lines |
0 comments
|
Download
|
 |
M |
media/audio/win/audio_output_win_unittest.cc
|
View
|
|
13 chunks |
+21 lines, -21 lines |
0 comments
|
Download
|
Total messages: 6 (2 generated)
|