third_party/libpng/README.chromium - Issue 2021403002: Update libpng to 1.6.22

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libpng/README.chromium

Issue 2021403002: Update libpng to 1.6.22 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Name: libpng	1 Name: libpng

2 URL: http://libpng.org/	2 URL: http://libpng.org/

3 Version: 1.2.56	3 Version: 1.6.22

4 Security Critical: yes	4 Security Critical: yes

5 License: libpng license	5 License: libpng license

6 License Android Compatible: yes	6 License Android Compatible: yes

7	7

8 Description:	8 Description:
	scroggo_chromium 2016/06/06 14:51:40 Did you also apply the intel patch? Did you also apply the intel patch? msarett 2016/06/06 18:01:57 Ahh yes, added bullet here. Show quoted text On 2016/06/06 14:51:40, scroggo_chromium wrote: > Did you also apply the intel patch? Ahh yes, added bullet here.
9 Updated to 1.2.56, no changes to the source files but all unneeded files	9 Updated to 1.6.22, stripped all unneeded files.

10 stripped.

11	10

12 Our custom configuration options are defined in pngusr.h. This was previously	11 - Use custom configuration file pnglibconf.h, which turns off all features that
	scroggo_chromium 2016/06/06 14:51:40 Is there an interesting section of pnglibconf.h (w Is there an interesting section of pnglibconf.h (which is a large file)? The version used by Skia is mostly a copy/rename of pnglibconf.h.prebuilt. (Actually, now that I look at it again, we no longer turn on/off any features, so it's just a rename, plus it's out of date (specifies the wrong version...).) It would be helpful if there was a section that is just the features we turned off at the end. msarett 2016/06/06 18:01:57 Yes, agreed! I've rearranged the file to group to Show quoted text On 2016/06/06 14:51:40, scroggo_chromium wrote: > Is there an interesting section of pnglibconf.h (which is a large file)? The > version used by Skia is mostly a copy/rename of pnglibconf.h.prebuilt. > (Actually, now that I look at it again, we no longer turn on/off any features, > so it's just a rename, plus it's out of date (specifies the wrong version...).) > > It would be helpful if there was a section that is just the features we turned > off at the end. Yes, agreed! I've rearranged the file to group together "default settings" and "chromium settings".
13 called mozpngconf.h, which was copied from Mozilla and modified by Apple (hence	12 are not in use.

14 the wk_* names):	13 - Use custom prefix file pngprefix.h, which avoids namespace conflicts with

15 - Unset PNG_NO_READ_PACK on Android in pngusr.h, required by freetype to support	14 pdfium's copy of libpng.

16 color glyphs.	15 - Configures custom png chunk user limits (crbug.com/117369) in pnglibconf.h.

17 - Configure PNG chunk user limits (crbug.com/117369)	16 - Fix for potential memory leak from upstream:

	17 https://github.com/glennrp/libpng/commit/8d1672537324d99c6e65eb78fc1678cdd46f7 5bd

	18 https://github.com/glennrp/libpng/commit/6c7459e455a4f7d95c7700e9326bb12396e6e b1f

	19 - Fix for handling empty first IDAT chunk from upstream:

	20 https://github.com/glennrp/libpng/commit/3f46c67c6989f480bd932428aa1705f6625db abf

	21 https://github.com/glennrp/libpng/commit/81f0273d54aa9de663253b197b3c8228d659c c36

OLD	NEW

« no previous file with comments | « third_party/libpng/README ('k') | third_party/libpng/arm/arm_init.c » ('j') | no next file with comments »