move BrowserFontResource_Trusted to content/child

move BrowserFontResource_Trusted to content/child

Needed to break dependency of ppapi_proxy on webkit code.

resource_creation_proxy now creates BrowserFontResource_Trusted
by going through PluginGlobals -> PluginProxyDelegate implemented
in content by PpapiThread.

R=jam@chromium.org, yzshen@chromium.org
BUG=237249
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213684

[scottmg, 2013-07-25 04:51:34]

jam: content/
yzshen: ppapi/

I'm not sure how to test this: If in buildtype=Official Flash can render fonts
does that seem sufficient?

[jam, 2013-07-25 04:59:22]

https://codereview.chromium.org/20214004/diff/15001/content/renderer/DEPS
File content/renderer/DEPS (right):

https://codereview.chromium.org/20214004/diff/15001/content/renderer/DEPS#new...
content/renderer/DEPS:3: "+content/ppapi_plugin",
this isn't correct, since one child directory can't include code from another.
if you want to share something, it would have to be in content/child

[scottmg, 2013-07-25 05:07:53]

https://codereview.chromium.org/20214004/diff/15001/content/renderer/DEPS
File content/renderer/DEPS (right):

https://codereview.chromium.org/20214004/diff/15001/content/renderer/DEPS#new...
content/renderer/DEPS:3: "+content/ppapi_plugin",
On 2013/07/25 04:59:22, jam wrote:
> this isn't correct, since one child directory can't include code from another.
> if you want to share something, it would have to be in content/child

thanks, done.

[scottmg, 2013-07-25 05:31:50]

On 2013/07/25 05:07:53, scottmg wrote:
> https://codereview.chromium.org/20214004/diff/15001/content/renderer/DEPS
> File content/renderer/DEPS (right):
> 
>
https://codereview.chromium.org/20214004/diff/15001/content/renderer/DEPS#new...
> content/renderer/DEPS:3: "+content/ppapi_plugin",
> On 2013/07/25 04:59:22, jam wrote:
> > this isn't correct, since one child directory can't include code from
another.
> > if you want to share something, it would have to be in content/child
> 
> thanks, done.

Hm, that's not going to work. It seems unfortunate that content/renderer/pepper
can't use the content/ppapi_plugin code.

[jam, 2013-07-25 16:16:50]

On 2013/07/25 05:31:50, scottmg wrote:
> On 2013/07/25 05:07:53, scottmg wrote:
> > https://codereview.chromium.org/20214004/diff/15001/content/renderer/DEPS
> > File content/renderer/DEPS (right):
> > 
> >
>
https://codereview.chromium.org/20214004/diff/15001/content/renderer/DEPS#new...
> > content/renderer/DEPS:3: "+content/ppapi_plugin",
> > On 2013/07/25 04:59:22, jam wrote:
> > > this isn't correct, since one child directory can't include code from
> another.
> > > if you want to share something, it would have to be in content/child
> > 
> > thanks, done.
> 
> Hm, that's not going to work.

what isn't working?

> It seems unfortunate that content/renderer/pepper
> can't use the content/ppapi_plugin code.

[scottmg, 2013-07-25 16:57:55]

On 2013/07/25 16:16:50, jam wrote:
> On 2013/07/25 05:31:50, scottmg wrote:
> > On 2013/07/25 05:07:53, scottmg wrote:
> > > https://codereview.chromium.org/20214004/diff/15001/content/renderer/DEPS
> > > File content/renderer/DEPS (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/20214004/diff/15001/content/renderer/DEPS#new...
> > > content/renderer/DEPS:3: "+content/ppapi_plugin",
> > > On 2013/07/25 04:59:22, jam wrote:
> > > > this isn't correct, since one child directory can't include code from
> > another.
> > > > if you want to share something, it would have to be in content/child
> > > 
> > > thanks, done.
> > 
> > Hm, that's not going to work.
> 
> what isn't working?

My brain, last night, it turns out. It's fine: PTAL at the latest.

[jam, 2013-07-25 17:20:24]

content lgtm

https://codereview.chromium.org/20214004/diff/32001/content/child/browser_fon...
File content/child/browser_font_resource_trusted.h (right):

https://codereview.chromium.org/20214004/diff/32001/content/child/browser_fon...
content/child/browser_font_resource_trusted.h:29: class CONTENT_EXPORT
BrowserFontResource_Trusted
are you sure it needs to be exported now? it doesn't look like it

https://codereview.chromium.org/20214004/diff/32001/content/ppapi_plugin/ppap...
File content/ppapi_plugin/ppapi_thread.cc (right):

https://codereview.chromium.org/20214004/diff/32001/content/ppapi_plugin/ppap...
content/ppapi_plugin/ppapi_thread.cc:221: ->GetReference();
nit: we usually don't start a line with "->"

https://codereview.chromium.org/20214004/diff/32001/ppapi/proxy/plugin_proxy_...
File ppapi/proxy/plugin_proxy_delegate.h (right):

https://codereview.chromium.org/20214004/diff/32001/ppapi/proxy/plugin_proxy_...
ppapi/proxy/plugin_proxy_delegate.h:38: virtual PP_Resource CreateBrowserFont(
nit: document

[yzshen1, 2013-07-25 17:21:08]

LGTM with a few nits.

Thanks!

https://codereview.chromium.org/20214004/diff/32001/content/content_child.gypi
File content/content_child.gypi (right):

https://codereview.chromium.org/20214004/diff/32001/content/content_child.gyp...
content/content_child.gypi:136: 'child/browser_font_resource_trusted.cc',
[nit] now that we have child/npapi,  does it make sense to add a subdir
child/ppapi/... ?

https://codereview.chromium.org/20214004/diff/32001/ppapi/proxy/plugin_globals.h
File ppapi/proxy/plugin_globals.h (right):

https://codereview.chromium.org/20214004/diff/32001/ppapi/proxy/plugin_global...
ppapi/proxy/plugin_globals.h:92: const ppapi::Preferences& prefs);
nit: ppapi:: is not needed.

https://codereview.chromium.org/20214004/diff/32001/ppapi/proxy/plugin_proxy_...
File ppapi/proxy/plugin_proxy_delegate.h (right):

https://codereview.chromium.org/20214004/diff/32001/ppapi/proxy/plugin_proxy_...
ppapi/proxy/plugin_proxy_delegate.h:42: const ppapi::Preferences& prefs) = 0;
nit: ppapi:: is not needed.

https://codereview.chromium.org/20214004/diff/32001/ppapi/proxy/ppapi_proxy_t...
File ppapi/proxy/ppapi_proxy_test.cc (right):

https://codereview.chromium.org/20214004/diff/32001/ppapi/proxy/ppapi_proxy_t...
ppapi/proxy/ppapi_proxy_test.cc:289: const ppapi::Preferences& prefs) {
nit: ppapi:: is not needed.

https://codereview.chromium.org/20214004/diff/32001/ppapi/proxy/ppapi_proxy_t...
File ppapi/proxy/ppapi_proxy_test.h (right):

https://codereview.chromium.org/20214004/diff/32001/ppapi/proxy/ppapi_proxy_t...
ppapi/proxy/ppapi_proxy_test.h:155: const ppapi::Preferences& prefs) OVERRIDE;
nit: ppapi:: is not needed.

[jam, 2013-07-25 17:23:23]

https://codereview.chromium.org/20214004/diff/32001/content/content_child.gypi
File content/content_child.gypi (right):

https://codereview.chromium.org/20214004/diff/32001/content/content_child.gyp...
content/content_child.gypi:136: 'child/browser_font_resource_trusted.cc',
On 2013/07/25 17:21:08, yzshen1 wrote:
> [nit] now that we have child/npapi,  does it make sense to add a subdir
> child/ppapi/... ?

let's wait until we have a bunch of pepper files first. content/child/npapi is
really the NPAPI equivalent of content/renderer/pepper

[yzshen1, 2013-07-25 17:24:52]

On 2013/07/25 17:23:23, jam wrote:
> https://codereview.chromium.org/20214004/diff/32001/content/content_child.gypi
> File content/content_child.gypi (right):
> 
>
https://codereview.chromium.org/20214004/diff/32001/content/content_child.gyp...
> content/content_child.gypi:136: 'child/browser_font_resource_trusted.cc',
> On 2013/07/25 17:21:08, yzshen1 wrote:
> > [nit] now that we have child/npapi,  does it make sense to add a subdir
> > child/ppapi/... ?
> 
> let's wait until we have a bunch of pepper files first. content/child/npapi is
> really the NPAPI equivalent of content/renderer/pepper

Okay. Thank!

[scottmg, 2013-07-25 17:39:49]

Thanks!

https://codereview.chromium.org/20214004/diff/32001/content/child/browser_fon...
File content/child/browser_font_resource_trusted.h (right):

https://codereview.chromium.org/20214004/diff/32001/content/child/browser_fon...
content/child/browser_font_resource_trusted.h:29: class CONTENT_EXPORT
BrowserFontResource_Trusted
On 2013/07/25 17:20:24, jam wrote:
> are you sure it needs to be exported now? it doesn't look like it

Done.

https://codereview.chromium.org/20214004/diff/32001/content/content_child.gypi
File content/content_child.gypi (right):

https://codereview.chromium.org/20214004/diff/32001/content/content_child.gyp...
content/content_child.gypi:136: 'child/browser_font_resource_trusted.cc',
On 2013/07/25 17:23:23, jam wrote:
> On 2013/07/25 17:21:08, yzshen1 wrote:
> > [nit] now that we have child/npapi,  does it make sense to add a subdir
> > child/ppapi/... ?
> 
> let's wait until we have a bunch of pepper files first. content/child/npapi is
> really the NPAPI equivalent of content/renderer/pepper

ok, i'll leave it here for now then.

https://codereview.chromium.org/20214004/diff/32001/content/ppapi_plugin/ppap...
File content/ppapi_plugin/ppapi_thread.cc (right):

https://codereview.chromium.org/20214004/diff/32001/content/ppapi_plugin/ppap...
content/ppapi_plugin/ppapi_thread.cc:221: ->GetReference();
On 2013/07/25 17:20:24, jam wrote:
> nit: we usually don't start a line with "->"

Done?

Previous version was clang-format output, but I'll file an internal bug and see
how c-style-arbitrers feel.

https://codereview.chromium.org/20214004/diff/32001/ppapi/proxy/plugin_globals.h
File ppapi/proxy/plugin_globals.h (right):

https://codereview.chromium.org/20214004/diff/32001/ppapi/proxy/plugin_global...
ppapi/proxy/plugin_globals.h:92: const ppapi::Preferences& prefs);
On 2013/07/25 17:21:08, yzshen1 wrote:
> nit: ppapi:: is not needed.

Done.

https://codereview.chromium.org/20214004/diff/32001/ppapi/proxy/plugin_proxy_...
File ppapi/proxy/plugin_proxy_delegate.h (right):

https://codereview.chromium.org/20214004/diff/32001/ppapi/proxy/plugin_proxy_...
ppapi/proxy/plugin_proxy_delegate.h:38: virtual PP_Resource CreateBrowserFont(
On 2013/07/25 17:20:24, jam wrote:
> nit: document

Done.

https://codereview.chromium.org/20214004/diff/32001/ppapi/proxy/plugin_proxy_...
ppapi/proxy/plugin_proxy_delegate.h:42: const ppapi::Preferences& prefs) = 0;
On 2013/07/25 17:21:08, yzshen1 wrote:
> nit: ppapi:: is not needed.

Done.

https://codereview.chromium.org/20214004/diff/32001/ppapi/proxy/ppapi_proxy_t...
File ppapi/proxy/ppapi_proxy_test.cc (right):

https://codereview.chromium.org/20214004/diff/32001/ppapi/proxy/ppapi_proxy_t...
ppapi/proxy/ppapi_proxy_test.cc:289: const ppapi::Preferences& prefs) {
On 2013/07/25 17:21:08, yzshen1 wrote:
> nit: ppapi:: is not needed.

Done.

https://codereview.chromium.org/20214004/diff/32001/ppapi/proxy/ppapi_proxy_t...
File ppapi/proxy/ppapi_proxy_test.h (right):

https://codereview.chromium.org/20214004/diff/32001/ppapi/proxy/ppapi_proxy_t...
ppapi/proxy/ppapi_proxy_test.h:155: const ppapi::Preferences& prefs) OVERRIDE;
On 2013/07/25 17:21:08, yzshen1 wrote:
> nit: ppapi:: is not needed.

Done.

[scottmg, 2013-07-25 19:25:58]

https://codereview.chromium.org/20214004/diff/32001/content/ppapi_plugin/ppap...
File content/ppapi_plugin/ppapi_thread.cc (right):

https://codereview.chromium.org/20214004/diff/32001/content/ppapi_plugin/ppap...
content/ppapi_plugin/ppapi_thread.cc:221: ->GetReference();
On 2013/07/25 17:39:49, scottmg wrote:
> On 2013/07/25 17:20:24, jam wrote:
> > nit: we usually don't start a line with "->"
> 
> Done?
> 
> Previous version was clang-format output, but I'll file an internal bug and
see
> how c-style-arbitrers feel.

(b/8071453 if you care to see how they feel)

[scottmg, 2013-07-25 20:25:54]

Committed patchset #7 manually as r213684 (presubmit successful).