Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4508)

Unified Diff: chrome/test/chromedriver/net/test_http_server.cc

Issue 2021393004: Migrate WaitableEvent to enum-based constructor in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WEvent_enums
Patch Set: Split out custom changes to thread_watcher_unittest.cc Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/net/test_http_server.cc
diff --git a/chrome/test/chromedriver/net/test_http_server.cc b/chrome/test/chromedriver/net/test_http_server.cc
index a9510b2eedd7329601f1b5c2dccd6a2c6e2b88be..ba863f95b424442dc8fbfe1ca7f120ea3f22652e 100644
--- a/chrome/test/chromedriver/net/test_http_server.cc
+++ b/chrome/test/chromedriver/net/test_http_server.cc
@@ -23,10 +23,10 @@ const int kBufferSize = 100 * 1024 * 1024; // 100 MB
TestHttpServer::TestHttpServer()
: thread_("ServerThread"),
- all_closed_event_(false, true),
+ all_closed_event_(base::WaitableEvent::ResetPolicy::AUTOMATIC,
+ base::WaitableEvent::InitialState::SIGNALED),
request_action_(kAccept),
- message_action_(kEchoMessage) {
-}
+ message_action_(kEchoMessage) {}
TestHttpServer::~TestHttpServer() {
}
@@ -38,7 +38,8 @@ bool TestHttpServer::Start() {
if (!thread_started)
return false;
bool success;
- base::WaitableEvent event(false, false);
+ base::WaitableEvent event(base::WaitableEvent::ResetPolicy::AUTOMATIC,
+ base::WaitableEvent::InitialState::NOT_SIGNALED);
thread_.task_runner()->PostTask(
FROM_HERE, base::Bind(&TestHttpServer::StartOnServerThread,
base::Unretained(this), &success, &event));
@@ -49,7 +50,8 @@ bool TestHttpServer::Start() {
void TestHttpServer::Stop() {
if (!thread_.IsRunning())
return;
- base::WaitableEvent event(false, false);
+ base::WaitableEvent event(base::WaitableEvent::ResetPolicy::AUTOMATIC,
+ base::WaitableEvent::InitialState::NOT_SIGNALED);
thread_.task_runner()->PostTask(
FROM_HERE, base::Bind(&TestHttpServer::StopOnServerThread,
base::Unretained(this), &event));

Powered by Google App Engine
This is Rietveld 408576698