chrome/test/chromedriver/net/sync_websocket_impl.cc - Issue 2021393004: Migrate WaitableEvent to enum-based constructor in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/net/sync_websocket_impl.cc

Issue 2021393004: Migrate WaitableEvent to enum-based constructor in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WEvent_enums

Patch Set: Split out custom changes to thread_watcher_unittest.cc Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/predictor.cc ('K') | « chrome/test/chromedriver/net/port_server_unittest.cc ('k') | chrome/test/chromedriver/net/sync_websocket_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/net/sync_websocket_impl.cc

diff --git a/chrome/test/chromedriver/net/sync_websocket_impl.cc b/chrome/test/chromedriver/net/sync_websocket_impl.cc

index 3650ef0df0b574b2a74bc3423ba93e91df969981..71f364ebc0eafce4b3a63b8902c7fa3b440c2751 100644

--- a/chrome/test/chromedriver/net/sync_websocket_impl.cc

+++ b/chrome/test/chromedriver/net/sync_websocket_impl.cc

@@ -53,7 +53,8 @@ bool SyncWebSocketImpl::Core::IsConnected() {

bool SyncWebSocketImpl::Core::Connect(const GURL& url) {

bool success = false;

- base::WaitableEvent event(false, false);

+ base::WaitableEvent event(base::WaitableEvent::ResetPolicy::AUTOMATIC,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

context_getter_->GetNetworkTaskRunner()->PostTask(

FROM_HERE,

base::Bind(&SyncWebSocketImpl::Core::ConnectOnIO,

@@ -64,7 +65,8 @@ bool SyncWebSocketImpl::Core::Connect(const GURL& url) {

bool SyncWebSocketImpl::Core::Send(const std::string& message) {