chrome/browser/sync/test/integration/passwords_helper.cc - Issue 2021393004: Migrate WaitableEvent to enum-based constructor in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/passwords_helper.cc

Issue 2021393004: Migrate WaitableEvent to enum-based constructor in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WEvent_enums

Patch Set: Split out custom changes to thread_watcher_unittest.cc Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/predictor.cc ('K') | « chrome/browser/sync/test/integration/extension_settings_helper.cc ('k') | chrome/browser/sync/test/integration/single_client_directory_sync_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/passwords_helper.cc

diff --git a/chrome/browser/sync/test/integration/passwords_helper.cc b/chrome/browser/sync/test/integration/passwords_helper.cc

index 3c18c9c7a87fe58fabf6f46fef6093bc2c690545..64fb1d9dcfcbcf267461e3e098e61c7e6de0b04f 100644

--- a/chrome/browser/sync/test/integration/passwords_helper.cc

+++ b/chrome/browser/sync/test/integration/passwords_helper.cc

@@ -75,7 +75,9 @@ namespace passwords_helper {

void AddLogin(PasswordStore* store, const PasswordForm& form) {

ASSERT_TRUE(store);

- base::WaitableEvent wait_event(true, false);

+ base::WaitableEvent wait_event(

+ base::WaitableEvent::ResetPolicy::MANUAL,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

store->AddLogin(form);

store->ScheduleTask(base::Bind(&PasswordStoreCallback, &wait_event));

wait_event.Wait();

@@ -83,7 +85,9 @@ void AddLogin(PasswordStore* store, const PasswordForm& form) {

void UpdateLogin(PasswordStore* store, const PasswordForm& form) {

ASSERT_TRUE(store);

- base::WaitableEvent wait_event(true, false);

+ base::WaitableEvent wait_event(

+ base::WaitableEvent::ResetPolicy::MANUAL,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

store->UpdateLogin(form);

store->ScheduleTask(base::Bind(&PasswordStoreCallback, &wait_event));

wait_event.Wait();

@@ -101,7 +105,9 @@ ScopedVector<PasswordForm> GetLogins(PasswordStore* store) {

void RemoveLogin(PasswordStore* store, const PasswordForm& form) {

ASSERT_TRUE(store);

- base::WaitableEvent wait_event(true, false);

+ base::WaitableEvent wait_event(

+ base::WaitableEvent::ResetPolicy::MANUAL,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

store->RemoveLogin(form);

store->ScheduleTask(base::Bind(&PasswordStoreCallback, &wait_event));

wait_event.Wait();