Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5657)

Unified Diff: chrome/browser/process_singleton_browsertest.cc

Issue 2021393004: Migrate WaitableEvent to enum-based constructor in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WEvent_enums
Patch Set: Split out custom changes to thread_watcher_unittest.cc Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/process_singleton_browsertest.cc
diff --git a/chrome/browser/process_singleton_browsertest.cc b/chrome/browser/process_singleton_browsertest.cc
index 02a30ce5f57865cabfa5f59a9a90eda7488bc6e4..c63d0e140187078429f1071831cc005cff1d8b30 100644
--- a/chrome/browser/process_singleton_browsertest.cc
+++ b/chrome/browser/process_singleton_browsertest.cc
@@ -45,12 +45,13 @@ namespace {
class ChromeStarter : public base::RefCountedThreadSafe<ChromeStarter> {
public:
ChromeStarter(base::TimeDelta timeout, const base::FilePath& user_data_dir)
- : ready_event_(false /* manual */, false /* signaled */),
- done_event_(false /* manual */, false /* signaled */),
+ : ready_event_(base::WaitableEvent::ResetPolicy::AUTOMATIC,
+ base::WaitableEvent::InitialState::NOT_SIGNALED),
+ done_event_(base::WaitableEvent::ResetPolicy::AUTOMATIC,
+ base::WaitableEvent::InitialState::NOT_SIGNALED),
process_terminated_(false),
timeout_(timeout),
- user_data_dir_(user_data_dir) {
- }
+ user_data_dir_(user_data_dir) {}
// We must reset some data members since we reuse the same ChromeStarter
// object and start/stop it a few times. We must start fresh! :-)
@@ -139,7 +140,8 @@ class ProcessSingletonTest : public InProcessBrowserTest {
ProcessSingletonTest()
// We use a manual reset so that all threads wake up at once when signaled
// and thus we must manually reset it for each attempt.
- : threads_waker_(true /* manual */, false /* signaled */) {
+ : threads_waker_(base::WaitableEvent::ResetPolicy::MANUAL,
+ base::WaitableEvent::InitialState::NOT_SIGNALED) {
EXPECT_TRUE(temp_profile_dir_.CreateUniqueTempDir());
}

Powered by Google App Engine
This is Rietveld 408576698