chrome/browser/password_manager/native_backend_kwallet_x.cc - Issue 2021393004: Migrate WaitableEvent to enum-based constructor in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/native_backend_kwallet_x.cc

Issue 2021393004: Migrate WaitableEvent to enum-based constructor in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WEvent_enums

Patch Set: Split out custom changes to thread_watcher_unittest.cc Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/predictor.cc ('K') | « chrome/browser/password_manager/native_backend_gnome_x.cc ('k') | chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/native_backend_kwallet_x.cc

diff --git a/chrome/browser/password_manager/native_backend_kwallet_x.cc b/chrome/browser/password_manager/native_backend_kwallet_x.cc

index 0ec2611793dbca2950c94ee42e3f7d63a89f62f5..d7b42791d3ce9acf15a6255a773795c7033ab827 100644

--- a/chrome/browser/password_manager/native_backend_kwallet_x.cc

+++ b/chrome/browser/password_manager/native_backend_kwallet_x.cc

@@ -344,7 +344,8 @@ bool NativeBackendKWallet::InitWithBus(scoped_refptr<dbus::Bus> optional_bus) {

// succeeds, but later, we'll want to do most work on the DB thread. So we

// have to do the initialization on the DB thread here too, and wait for it.

bool success = false;

- base::WaitableEvent event(false, false);

+ base::WaitableEvent event(base::WaitableEvent::ResetPolicy::AUTOMATIC,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

// NativeBackendKWallet isn't reference counted, but we wait for InitWithBus

// to finish, so we can safely use base::Unretained here.

BrowserThread::PostTask(BrowserThread::DB, FROM_HERE,