Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2021373002: Refactor Maps' code_cache (Closed)

Created:
4 years, 6 months ago by Jakob Kummerow
Modified:
4 years, 6 months ago
Reviewers:
ulan, Toon Verwaest
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Refactor Maps' code_cache Most maps have a small code cache (often only one entry), so this patch optimizes memory consumption of such cases by using plain FixedArrays, only switching to CodeCacheHashTables when the number of cached entries gets so large that linear-scan lookups get too slow. On loading inbox.google.com, this gets the aggregate size of all maps' code caches (there are about 13,600 of them) from 4300 KB to 970 KB. Committed: https://crrev.com/31882103773436538fa929b1b867a6cb42fe72bf Cr-Commit-Position: refs/heads/master@{#36681}

Patch Set 1 #

Patch Set 2 : add test and rebase #

Patch Set 3 : windows don't want no constexpr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -22 lines) Patch
M src/heap/object-stats.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 2 chunks +1 line, -4 lines 0 comments Download
M src/objects.cc View 1 2 1 chunk +171 lines, -14 lines 0 comments Download
M src/objects-inl.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M test/cctest/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/test-code-cache.cc View 1 1 chunk +75 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Jakob Kummerow
Toon: as discussed, PTAL. Ulan/Hannes: I can haz heap rubberstamp plz?
4 years, 6 months ago (2016-06-02 11:39:09 UTC) #3
Toon Verwaest
Very nice, LGTM.
4 years, 6 months ago (2016-06-02 12:01:19 UTC) #4
ulan
heap lgtm
4 years, 6 months ago (2016-06-02 12:28:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021373002/20001
4 years, 6 months ago (2016-06-02 12:33:18 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/8070)
4 years, 6 months ago (2016-06-02 12:38:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021373002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021373002/40001
4 years, 6 months ago (2016-06-02 12:46:18 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-02 13:16:50 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 13:19:33 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/31882103773436538fa929b1b867a6cb42fe72bf
Cr-Commit-Position: refs/heads/master@{#36681}

Powered by Google App Engine
This is Rietveld 408576698