Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 2021363002: Fix positioning of widgets (Closed)

Created:
4 years, 6 months ago by Stephen Chennney
Modified:
4 years, 6 months ago
Reviewers:
Fady Samuel, lazyboy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Fix positioning of widgets The BrowserPlugin updateGeometry code was only sending a UpdateGeometry message to its host if the rect was the _same_ as the previous rect. This required two calls to the method in order to get the message sent, and no doubt resulted in the message being sent every time the geometry was the same and never when it was different. R=fsamuel@chromium.org, lazyboy@chromium.org BUG=555201, 596494 Review-Url: https://codereview.chromium.org/1958903005 Cr-Commit-Position: refs/heads/master@{#394808} (cherry picked from commit b999309cd9ace1b703df73ed50d1c0d9efde90fa) Committed: https://chromium.googlesource.com/chromium/src/+/859ed4fe376118092b622b79c99650e13704a3a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Stephen Chennney
4 years, 6 months ago (2016-05-31 17:02:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
859ed4fe376118092b622b79c99650e13704a3a4.

Powered by Google App Engine
This is Rietveld 408576698