Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2021343004: Add a test for crbug 613918 and fix a style issue. (Closed)

Created:
4 years, 6 months ago by Martin Barbella
Modified:
4 years, 6 months ago
Reviewers:
caryclark, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add a test to ensure that a case where SkCubicClipper::ChopMonoAtY returns false is handled properly. Also fixes a style issue in the fix for the issue being tested. BUG=chromium:613918 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2021343004 Committed: https://skia.googlesource.com/skia/+/99600d0a158e3b2f1ff077a6fd102e78ce9db0e4

Patch Set 1 #

Patch Set 2 : Minimize test and add a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M src/core/SkPath.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/PathTest.cpp View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Martin Barbella
PTAL when you get a chance.
4 years, 6 months ago (2016-06-01 04:51:00 UTC) #4
caryclark
lgtm
4 years, 6 months ago (2016-06-01 11:42:32 UTC) #5
reed1
I cannot view the bug. The CL comment is sort of meaningless without it. Can ...
4 years, 6 months ago (2016-06-01 13:10:29 UTC) #7
Martin Barbella
You should be cced on the bug with your @google.com account, but agreed that this ...
4 years, 6 months ago (2016-06-01 15:47:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021343004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021343004/20001
4 years, 6 months ago (2016-06-01 22:22:54 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 22:39:53 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/99600d0a158e3b2f1ff077a6fd102e78ce9db0e4

Powered by Google App Engine
This is Rietveld 408576698