Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: chrome/test/data/webui/settings/site_settings_category_tests.js

Issue 2021343003: MD Site Settings: Add five new top level categories (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Unit test fix Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/site_settings_category_tests.js
diff --git a/chrome/test/data/webui/settings/site_settings_category_tests.js b/chrome/test/data/webui/settings/site_settings_category_tests.js
index ed1da65ceabed3110ca54f955a44decd7e623959..068cc7ac976677ac5097f423ab48255592c7d07c 100644
--- a/chrome/test/data/webui/settings/site_settings_category_tests.js
+++ b/chrome/test/data/webui/settings/site_settings_category_tests.js
@@ -121,9 +121,15 @@ cr.define('site_settings_category', function() {
'', testElement.computeCategoryDesc(category, false, false));
}
- // All categories have an icon and a title.
- assertNotEquals(
- '', testElement.computeIconForContentCategory(category));
+ // All categories have an icon (except for a couple) and a title.
+ if (category != settings.ContentSettingsTypes.AUTOMATIC_DOWNLOADS &&
+ category != settings.ContentSettingsTypes.BACKGROUND_SYNC &&
+ category != settings.ContentSettingsTypes.KEYGEN &&
+ category != settings.ContentSettingsTypes.PLUGINS &&
+ category != settings.ContentSettingsTypes.UNSANDBOXED_PLUGINS) {
+ assertNotEquals(
+ '', testElement.computeIconForContentCategory(category));
+ }
assertNotEquals(
'', testElement.computeTitleForContentCategory(category));
}

Powered by Google App Engine
This is Rietveld 408576698