Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: chrome/browser/resources/settings/site_settings_page/site_settings_page.html

Issue 2021343003: MD Site Settings: Add five new top level categories (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Unit test fix Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings_page/site_settings_page.html
diff --git a/chrome/browser/resources/settings/site_settings_page/site_settings_page.html b/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
index d463eaad6335c23d6e150a22acb9df6aed687280..e808bc1ac7785e249af0a5b3c27f28ccf38b0d31 100644
--- a/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
+++ b/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
@@ -74,6 +74,16 @@
</div>
</div>
<div class="settings-box two-line"
+ category$="[[ContentSettingsTypes.PLUGINS]]"
+ on-tap="onTapCategory">
+ <iron-icon icon="[[computeIconForContentCategory(
+ ContentSettingsTypes.PLUGINS)]]" item-icon=""></iron-icon>
+ <div class="middle">
+ [[computeTitleForContentCategory(ContentSettingsTypes.PLUGINS)]]
+ <div id="plugins" class="secondary"></div>
+ </div>
+ </div>
+ <div class="settings-box two-line"
category$="[[ContentSettingsTypes.IMAGES]]" on-tap="onTapCategory">
<iron-icon icon="[[computeIconForContentCategory(
ContentSettingsTypes.IMAGES)]]" item-icon=""></iron-icon>
@@ -91,6 +101,50 @@
<div id="popups" class="secondary"></div>
</div>
</div>
+ <div class="settings-box two-line"
+ category$="[[ContentSettingsTypes.BACKGROUND_SYNC]]"
+ on-tap="onTapCategory">
+ <iron-icon icon="[[computeIconForContentCategory(
+ ContentSettingsTypes.BACKGROUND_SYNC)]]" item-icon=""></iron-icon>
+ <div class="middle">
+ [[computeTitleForContentCategory(
+ ContentSettingsTypes.BACKGROUND_SYNC)]]
michaelpg 2016/06/02 12:58:30 +2 indent
Finnur 2016/06/02 17:31:36 I'm confused... For HTML we use a 2 space indent a
michaelpg 2016/06/03 13:37:14 We have a new style guideline of wrapping computed
+ <div id="backgroundSync" class="secondary"></div>
+ </div>
+ </div>
+ <div class="settings-box two-line"
+ category$="[[ContentSettingsTypes.KEYGEN]]"
+ on-tap="onTapCategory">
+ <iron-icon icon="[[computeIconForContentCategory(
+ ContentSettingsTypes.KEYGEN)]]" item-icon=""></iron-icon>
+ <div class="middle">
+ [[computeTitleForContentCategory(
+ ContentSettingsTypes.KEYGEN)]]
michaelpg 2016/06/02 12:58:30 +2 indent
+ <div id="keygen" class="secondary"></div>
+ </div>
+ </div>
+ <div class="settings-box two-line"
+ category$="[[ContentSettingsTypes.AUTOMATIC_DOWNLOADS]]"
+ on-tap="onTapCategory">
+ <iron-icon icon="[[computeIconForContentCategory(
+ ContentSettingsTypes.AUTOMATIC_DOWNLOADS)]]" item-icon=""></iron-icon>
+ <div class="middle">
+ [[computeTitleForContentCategory(
+ ContentSettingsTypes.AUTOMATIC_DOWNLOADS)]]
michaelpg 2016/06/02 12:58:31 +2 indent
+ <div id="automaticDownloads" class="secondary"></div>
+ </div>
+ </div>
+ <div class="settings-box two-line"
+ category$="[[ContentSettingsTypes.UNSANDBOXED_PLUGINS]]"
+ on-tap="onTapCategory">
+ <iron-icon icon="[[computeIconForContentCategory(
+ ContentSettingsTypes.UNSANDBOXED_PLUGINS)]]" item-icon=""></iron-icon>
+ <div class="middle">
+ [[computeTitleForContentCategory(
+ ContentSettingsTypes.UNSANDBOXED_PLUGINS)]]
michaelpg 2016/06/02 12:58:30 +2 indent
+ <div id="unsandboxedPlugins" class="secondary"></div>
+ </div>
+ </div>
</template>
<script src="site_settings_page.js"></script>
</dom-module>

Powered by Google App Engine
This is Rietveld 408576698