chrome/browser/resources/settings/site_settings/site_details.html - Issue 2021343003: MD Site Settings: Add five new top level categories

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/site_details.html

Issue 2021343003: MD Site Settings: Add five new top level categories (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unit test fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/settings_strings.grdp ('K') | « chrome/browser/resources/settings/site_settings/constants.js ('k') | chrome/browser/resources/settings/site_settings/site_details_permission.js » ('j') | chrome/browser/resources/settings/site_settings/site_details_permission.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings/site_details.html

diff --git a/chrome/browser/resources/settings/site_settings/site_details.html b/chrome/browser/resources/settings/site_settings/site_details.html

index 4969b9f8a5006a4e61b52130eeeef82fec830685..35325250ec6ed9c2675174e134265cf62b6ba4e5 100644

--- a/chrome/browser/resources/settings/site_settings/site_details.html

+++ b/chrome/browser/resources/settings/site_settings/site_details.html

@@ -75,9 +75,24 @@

<site-details-permission site="[[site]]" id="javascript"

category="{{ContentSettingsTypes.JAVASCRIPT}}">

</site-details-permission>

+ <site-details-permission site="[[site]]" id="javascript"

michaelpg 2016/06/02 12:58:30 plugins

Finnur 2016/06/02 17:31:36 Good catch. Done.

+ category="{{ContentSettingsTypes.PLUGINS}}">

+ </site-details-permission>

<site-details-permission site="[[site]]" id="popups"

category="{{ContentSettingsTypes.POPUPS}}">

</site-details-permission>

+ <site-details-permission site="[[site]]" id="backgroundSync"

+ category="{{ContentSettingsTypes.BACKGROUND_SYNC}}">

+ </site-details-permission>

+ <site-details-permission site="[[site]]" id="keygen"

+ category="{{ContentSettingsTypes.KEYGEN}}">

+ </site-details-permission>

+ <site-details-permission site="[[site]]" id="automaticDownloads"

+ category="{{ContentSettingsTypes.AUTOMATIC_DOWNLOADS}}">

+ </site-details-permission>

+ <site-details-permission site="[[site]]" id="unsandboxedPlugins"

+ category="{{ContentSettingsTypes.UNSANDBOXED_PLUGINS}}">

+ </site-details-permission>

<site-details-permission site="[[site]]" id="fullscreen"

category="{{ContentSettingsTypes.FULLSCREEN}}">

</site-details-permission>