MD Site Settings: Add five new top level categories

chrome/browser/resources/settings/site_settings/site_details_permission.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'site-details-permission' handles showing the state of one permission, such
  * as Geolocation, for a given origin.
  */
 Polymer({
@@ skipping 33 matching lines @@
    * Sets the site to display.
    * @param {!SiteException} site The site to display.
    * @private
    */
   siteChanged_: function(site) {
     this.$.details.hidden = true;
 
     this.browserProxy.getExceptionList(this.category).then(
         function(exceptionList) {
       for (var i = 0; i < exceptionList.length; ++i) {
-        if (exceptionList[i].origin == site.origin) {
+        var origin = this.removePatternWildcard_(exceptionList[i].origin);
+        if (origin == this.removePatternWildcard_(site.origin)) {

[michaelpg, 2016/06/02 12:58:30]

nit: you could make a comparison function instead of running the function twice
with a temporary variable:

    if (this.sameOrigin_(exceptionList[i].origin, site.origin)) {

[Finnur, 2016/06/02 17:31:36]

Done.

[michaelpg, 2016/06/03 13:37:14]

Thanks, definitely more readable!

           this.$.permission.selected = exceptionList[i].setting;
           this.$.details.hidden = false;
         }
       }
     }.bind(this));
   },
 
   /**
    * Called when a site within a category has been changed.
    * @param {number} category The category that changed.
@@ skipping 24 matching lines @@
   /**
    * Handles the category permission changing for this origin.
    * @param {!{detail: !{item: !{dataset: !{permissionValue: string}}}}} event
    */
   onPermissionMenuIronActivate_: function(event) {
     var value = event.detail.item.dataset.permissionValue;
     this.setCategoryPermissionForOrigin(
         this.site.origin, '', this.category, value);
   },
 });