src/ia32/assembler-ia32-inl.h - Issue 2021323003: [wasm] remove faux code objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/assembler-ia32-inl.h

Issue 2021323003: [wasm] remove faux code objects Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/assembler-ia32-inl.h

diff --git a/src/ia32/assembler-ia32-inl.h b/src/ia32/assembler-ia32-inl.h

index 2120a90e0ceda66820b8a9c54a82571ffac3f39a..6ddde34c4a700488e55b4afa9760ea3d7f01664c 100644

--- a/src/ia32/assembler-ia32-inl.h

+++ b/src/ia32/assembler-ia32-inl.h

@@ -105,7 +105,8 @@ void RelocInfo::set_target_address(Address target,

ICacheFlushMode icache_flush_mode) {

Assembler::set_target_address_at(isolate_, pc_, host_, target,

icache_flush_mode);

- DCHECK(IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_));

+ DCHECK(IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_) ||

+ IsWasmDirectCall(rmode_));

if (write_barrier_mode == UPDATE_WRITE_BARRIER && host() != NULL &&

IsCodeTarget(rmode_)) {

Object* target_code = Code::GetCodeFromTargetAddress(target);