[wasm] remove faux code objects

src/arm/assembler-arm.cc

 // Copyright (c) 1994-2006 Sun Microsystems Inc.
 // All Rights Reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
 // are met:
 //
 // - Redistributions of source code must retain the above copyright notice,
 // this list of conditions and the following disclaimer.
 //
@@ skipping 231 matching lines @@
 Address RelocInfo::wasm_memory_reference() {
   DCHECK(IsWasmMemoryReference(rmode_));
   return Assembler::target_address_at(pc_, host_);
 }
 
 uint32_t RelocInfo::wasm_memory_size_reference() {
   DCHECK(IsWasmMemorySizeReference(rmode_));
   return reinterpret_cast<uint32_t>(Assembler::target_address_at(pc_, host_));
 }
 
+uint32_t RelocInfo::wasm_function_index() {

[titzer, 2016/06/02 13:17:08]

This function basically assumes that the call site has not been patched to
already refer directly to the address which is being called. If this function is
called after the WASM call is patched, this is going to return that address.

How will this work with serialization/deserialization?

[Mircea Trofin, 2016/06/02 14:46:21]

The statement about the assumption is correct.

Serialization/deserialization are not affected. We can do them either before or
after linking. We just need to avoid linking twice. I validated doing ser/deser
before linking locally.

+  DCHECK(IsWasmDirectCall(rmode_));
+  return reinterpret_cast<uint32_t>(Assembler::target_address_at(pc_, host_));
+}
+
 void RelocInfo::update_wasm_memory_reference(
     Address old_base, Address new_base, uint32_t old_size, uint32_t new_size,
     ICacheFlushMode icache_flush_mode) {
   DCHECK(IsWasmMemoryReference(rmode_) || IsWasmMemorySizeReference(rmode_));
   if (IsWasmMemoryReference(rmode_)) {
     Address updated_memory_reference;
     DCHECK(old_base <= wasm_memory_reference() &&
            wasm_memory_reference() < old_base + old_size);
     updated_memory_reference = new_base + (wasm_memory_reference() - old_base);
     DCHECK(new_base <= updated_memory_reference &&
@@ skipping 4029 matching lines @@
     DCHECK(is_uint12(offset));
     instr_at_put(pc, SetLdrRegisterImmediateOffset(instr, offset));
   }
 }
 
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_TARGET_ARCH_ARM