Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2021303002: Simple Cache: avoid extraneous stream 0 (http header) writes. (Closed)

Created:
4 years, 6 months ago by gavinp
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Simple Cache: avoid extraneous stream 0 (http header) writes. These writes were not only wasteful, but they could cause corruption if the existing EOF record didn't have a key SHA256; the new key SHA256 would overwrite the existing one corrupting the entry. BUG=615440 R=juliatuttle@chromium.org,rdsmith@chromium.org Review-Url: https://codereview.chromium.org/2015263002 Cr-Commit-Position: refs/heads/master@{#396533} (cherry picked from commit 6b66971b761a15a67982bef692619a96f306150d) Committed: https://chromium.googlesource.com/chromium/src/+/53f45d9bb2f4c767fc1edbed08d31edecaeb4fff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -18 lines) Patch
M net/disk_cache/entry_unittest.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M net/disk_cache/simple/simple_synchronous_entry.cc View 2 chunks +20 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
gavinp
4 years, 6 months ago (2016-05-31 14:49:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
53f45d9bb2f4c767fc1edbed08d31edecaeb4fff.

Powered by Google App Engine
This is Rietveld 408576698