Skip profiles in GetLastOpenedProfiles that fail to initialize

chrome/browser/ui/startup/startup_browser_creator.cc

Index: chrome/browser/ui/startup/startup_browser_creator.cc
diff --git a/chrome/browser/ui/startup/startup_browser_creator.cc b/chrome/browser/ui/startup/startup_browser_creator.cc
index ae452e2147b43d43a91959a13816f10982390848..05a2c4cae80c5bd36aebab2d657570ef2040a78e 100644
--- a/chrome/browser/ui/startup/startup_browser_creator.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator.cc
@@ -747,6 +747,8 @@ bool StartupBrowserCreator::ProcessCmdLineImpl(
   // - Only incognito windows were open when the browser exited.
   // |last_used_profile| is the last used incognito profile. Restoring it will
   // create a browser window for the corresponding original profile.
+  // - All of the last opened profiles fail to initialize, i.e. having all
+  // nullptr returns in Profile::CreateProfile.

[Peter Kasting, 2016/05/31 19:12:30]

Nit: I'd probably just leave off the second clause here since it discusses an
implementation detail of a function that's elsewhere; if we modify how that
function works or what things are named this comment could go out of date, and
the first clause seems descriptive enough.

If you really feel like more detail is required, perhaps instead say something
like "i.e. all such profiles encounter disk errors on creation".

[WC Leung, 2016/06/01 18:56:55]

I see. Now the second clause is removed.

   if (last_opened_profiles.empty()) {
     if (ShowUserManagerOnStartupIfNeeded(last_used_profile, command_line))
       return true;