Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2021173002: Implement cc::BeginFrameArgs StructTraits (Closed)

Created:
4 years, 6 months ago by Fady Samuel
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez, piman
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nona+watch_chromium.org, shuchen+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, James Su, ben+mojo_chromium.org, darin (slow to review), yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement cc::BeginFrameArgs StructTraits BUG=611802 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/8e8d87293a23809d6523c4d4faddbc5cca33de39 Cr-Commit-Position: refs/heads/master@{#397140}

Patch Set 1 #

Patch Set 2 : Fix DEPS file #

Patch Set 3 : Fix gyp build #

Patch Set 4 : Rebased #

Patch Set 5 : Removed bad file #

Patch Set 6 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -0 lines) Patch
M cc/ipc/BUILD.gn View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
A cc/ipc/begin_frame_args.mojom View 1 chunk +23 lines, -0 lines 0 comments Download
A cc/ipc/begin_frame_args.typemap View 1 chunk +9 lines, -0 lines 0 comments Download
A cc/ipc/begin_frame_args_struct_traits.h View 1 chunk +51 lines, -0 lines 0 comments Download
M cc/ipc/struct_traits_unittest.cc View 1 2 3 4 5 2 chunks +32 lines, -0 lines 0 comments Download
M cc/ipc/traits_test_service.mojom View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M cc/ipc/typemaps.gni View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 33 (17 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021173002/1
4 years, 6 months ago (2016-05-31 03:02:47 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/13363) ios-device-gn on ...
4 years, 6 months ago (2016-05-31 03:04:26 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021173002/20001
4 years, 6 months ago (2016-05-31 03:14:11 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/13372) ios-device-gn on ...
4 years, 6 months ago (2016-05-31 03:15:29 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021173002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021173002/40001
4 years, 6 months ago (2016-05-31 04:02:55 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/13386) ios-device-gn on ...
4 years, 6 months ago (2016-05-31 04:04:09 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021173002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021173002/60001
4 years, 6 months ago (2016-05-31 15:11:38 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/13527) ios-device-gn on ...
4 years, 6 months ago (2016-05-31 15:13:42 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021173002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021173002/80001
4 years, 6 months ago (2016-05-31 15:21:40 UTC) #20
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-31 17:45:59 UTC) #22
Fady Samuel
+tsepez@ for pc +piman@ for overall cc change.
4 years, 6 months ago (2016-05-31 19:54:38 UTC) #24
Tom Sepez
lgtm
4 years, 6 months ago (2016-05-31 20:01:05 UTC) #25
piman
lgtm
4 years, 6 months ago (2016-05-31 22:24:11 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021173002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021173002/100001
4 years, 6 months ago (2016-06-01 12:08:57 UTC) #29
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 6 months ago (2016-06-01 14:57:56 UTC) #31
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 15:00:04 UTC) #33
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/8e8d87293a23809d6523c4d4faddbc5cca33de39
Cr-Commit-Position: refs/heads/master@{#397140}

Powered by Google App Engine
This is Rietveld 408576698