Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2021143003: [builtins] Migrate String.fromCharCode to TurboFan code stub. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Migrate String.fromCharCode to TurboFan code stub. When we moved the String.fromCharCode builtin to C++, we slightly regressed the fast single character code argument case. Recovered some of the performance by implementing the builtin using the TurboFan CodeStubAssembler. Drive-by-fix: Make sure the stack trace from the implicit ToNumber conversion in String.fromCharCode includes the builtin by adding a regression test for that. R=yangguo@chromium.org BUG=chromium:609831, chromium:613947, v8:5049 Committed: https://crrev.com/7554360f28adebd086761c3636c004a1013ebbb5 Cr-Commit-Position: refs/heads/master@{#36611}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+315 lines, -55 lines) Patch
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins.h View 3 chunks +3 lines, -1 line 0 comments Download
M src/builtins.cc View 1 chunk +177 lines, -53 lines 0 comments Download
M src/code-stub-assembler.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 2 chunks +82 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +19 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-string-from-char-code-tonumber.js View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Benedikt Meurer
4 years, 6 months ago (2016-05-31 10:57:10 UTC) #1
Benedikt Meurer
Hey Yang, Some followup performance work for String.fromCharCode. Please take a look. Thanks, Benedikt
4 years, 6 months ago (2016-05-31 10:58:24 UTC) #3
Yang
On 2016/05/31 10:58:24, Benedikt Meurer wrote: > Hey Yang, > > Some followup performance work ...
4 years, 6 months ago (2016-05-31 11:34:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021143003/1
4 years, 6 months ago (2016-05-31 11:35:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 11:37:32 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 11:39:16 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7554360f28adebd086761c3636c004a1013ebbb5
Cr-Commit-Position: refs/heads/master@{#36611}

Powered by Google App Engine
This is Rietveld 408576698