pkg/compiler/lib/src/compile_time_constants.dart - Issue 2021133003: Revert "Introduces "--initializing-formal-access"."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/compile_time_constants.dart

Issue 2021133003: Revert "Introduces "--initializing-formal-access"." (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/compile_time_constants.dart

diff --git a/pkg/compiler/lib/src/compile_time_constants.dart b/pkg/compiler/lib/src/compile_time_constants.dart

index e5626dc5196b7d9f7db2c22a1f9c7c3518ed1537..9bab3a5f51368b109edcb5962d8032a682c56d44 100644

--- a/pkg/compiler/lib/src/compile_time_constants.dart

+++ b/pkg/compiler/lib/src/compile_time_constants.dart

@@ -1182,9 +1182,6 @@ class ConstructorEvaluator extends CompileTimeConstantEvaluator {

if (parameter.isInitializingFormal) {

InitializingFormalElement initializingFormal = parameter;

updateFieldValue(node, initializingFormal.fieldElement, argument);

- if (compiler.options.enableInitializingFormalAccess) {

- definitions[parameter] = argument;

- }

} else {

potentiallyCheckType(parameter, argument);

definitions[parameter] = argument;

« no previous file with comments | « pkg/compiler/lib/src/commandline_options.dart ('k') | pkg/compiler/lib/src/dart2js.dart » ('j') | no next file with comments »