Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 202113008: Further tweak compare_codereview.py. (Closed)

Created:
6 years, 9 months ago by mtklein_C
Modified:
6 years, 9 months ago
Reviewers:
hal.canary, mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Further tweak compare_codereview.py. - only show details for bots where at least one side failed - dedup identical failures BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13942

Patch Set 1 #

Patch Set 2 : 2 space, 80 col #

Unified diffs Side-by-side diffs Delta from patch set Stats (+365 lines, -346 lines) Patch
M tools/compare_codereview.py View 1 1 chunk +365 lines, -346 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 9 months ago (2014-03-25 15:38:54 UTC) #1
hal.canary
LGTM if it works.
6 years, 9 months ago (2014-03-25 16:06:39 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 9 months ago (2014-03-25 16:58:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/202113008/40001
6 years, 9 months ago (2014-03-25 16:58:40 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 18:02:19 UTC) #5
Message was sent while issue was closed.
Change committed as 13942

Powered by Google App Engine
This is Rietveld 408576698