Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 202113005: Fix HttpLogUtilTest.ElideHeaderValueForNetLog. (Closed)

Created:
6 years, 9 months ago by davidben
Modified:
6 years, 9 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, Kibeom Kim (inactive)
Visibility:
Public.

Description

Fix HttpLogUtilTest.ElideHeaderValueForNetLog. It's broken on downstream bots. BUG=353798 R=mmenke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258084

Patch Set 1 #

Total comments: 2

Patch Set 2 : Cut down on redundancy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M net/http/http_log_util_unittest.cc View 1 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
davidben
6 years, 9 months ago (2014-03-19 16:01:16 UTC) #1
mmenke
https://codereview.chromium.org/202113005/diff/1/net/http/http_log_util_unittest.cc File net/http/http_log_util_unittest.cc (right): https://codereview.chromium.org/202113005/diff/1/net/http/http_log_util_unittest.cc#newcode74 net/http/http_log_util_unittest.cc:74: #endif Wonder if we really need quite so many ...
6 years, 9 months ago (2014-03-19 16:19:08 UTC) #2
mmenke
Oh, and LGTM
6 years, 9 months ago (2014-03-19 16:19:14 UTC) #3
davidben
Cut down on the redundancy.
6 years, 9 months ago (2014-03-19 16:44:42 UTC) #4
mmenke
On 2014/03/19 16:44:42, David Benjamin wrote: > Cut down on the redundancy. Still LGTM
6 years, 9 months ago (2014-03-19 17:48:34 UTC) #5
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 9 months ago (2014-03-19 17:56:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/202113005/20001
6 years, 9 months ago (2014-03-19 17:58:24 UTC) #7
davidben
On 2014/03/19 17:58:24, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 9 months ago (2014-03-19 20:48:56 UTC) #8
davidben
The CQ bit was unchecked by davidben@chromium.org
6 years, 9 months ago (2014-03-19 20:48:59 UTC) #9
davidben
6 years, 9 months ago (2014-03-19 20:50:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 manually as r258084 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698