|
Implement ScopedFD in terms of ScopedGeneric.
Move to a new file base/files/scoped_file.h. I will also add ScopedFILE to here (currently in file_util.h) later.
I think there is a crash in the old code in content/browser/zygote_host/zygote_host_impl_linux.cc that this patch should fix. The old ScopedFD took the address of something in a vector that is being modified.
I removed SafeScopedFD from content/common/sandbox_linux/sandbox_linux.cc since base's ScopedFD not CHECKs on close failure (this is a more recent addition).
Reland of https://codereview.chromium.org/191673003/
R=agl, viettrungluu
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257473
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+331 lines, -286 lines) |
Patch |
|
M |
base/BUILD.gn
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
base/base.gypi
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
base/debug/proc_maps_linux.cc
|
View
|
|
3 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
base/file_util.h
|
View
|
|
1 chunk |
+0 lines, -26 lines |
0 comments
|
Download
|
|
M |
base/file_util_posix.cc
|
View
|
|
3 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
|
M |
base/file_util_unittest.cc
|
View
|
|
3 chunks |
+5 lines, -4 lines |
0 comments
|
Download
|
|
A |
base/files/scoped_file.h
|
View
|
|
1 chunk |
+47 lines, -0 lines |
0 comments
|
Download
|
|
A |
base/files/scoped_file.cc
|
View
|
|
1 chunk |
+35 lines, -0 lines |
0 comments
|
Download
|
|
M |
base/memory/discardable_memory_allocator_android.cc
|
View
|
|
3 chunks |
+6 lines, -7 lines |
0 comments
|
Download
|
|
M |
base/memory/shared_memory.h
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
base/memory/shared_memory_posix.cc
|
View
|
|
8 chunks |
+10 lines, -14 lines |
0 comments
|
Download
|
|
M |
base/posix/unix_domain_socket_linux_unittest.cc
|
View
|
|
3 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
base/process/kill_mac.cc
|
View
|
|
3 chunks |
+5 lines, -6 lines |
0 comments
|
Download
|
|
M |
base/process/kill_posix.cc
|
View
|
|
3 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
base/process/launch_posix.cc
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
base/test/launcher/test_launcher.cc
|
View
|
|
3 chunks |
+9 lines, -10 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/system/automatic_reboot_manager.cc
|
View
|
|
3 chunks |
+11 lines, -10 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc
|
View
|
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc
|
View
|
|
3 chunks |
+9 lines, -8 lines |
0 comments
|
Download
|
|
M |
chrome/browser/mac/relauncher.cc
|
View
|
|
7 chunks |
+11 lines, -13 lines |
0 comments
|
Download
|
|
M |
chrome/browser/process_singleton_mac_unittest.cc
|
View
|
|
2 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/test/automation/proxy_launcher.cc
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/test/chromedriver/chrome_launcher.cc
|
View
|
|
2 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/utility/importer/firefox_importer_unittest_utils_mac.cc
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
content/browser/child_process_launcher.cc
|
View
|
|
3 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/browser/zygote_host/zygote_host_impl_linux.cc
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
content/child/npapi/np_channel_base.cc
|
View
|
|
3 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
content/common/sandbox_linux/sandbox_linux.cc
|
View
|
|
4 chunks |
+11 lines, -15 lines |
0 comments
|
Download
|
|
M |
content/common/sandbox_mac.mm
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
content/common/sandbox_mac_system_access_unittest.mm
|
View
|
|
3 chunks |
+6 lines, -7 lines |
0 comments
|
Download
|
|
M |
ipc/ipc_channel_factory.cc
|
View
|
|
2 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
ipc/unix_domain_socket_util.cc
|
View
|
|
7 chunks |
+21 lines, -22 lines |
0 comments
|
Download
|
|
M |
media/video/capture/linux/video_capture_device_linux.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
media/video/capture/linux/video_capture_device_linux.cc
|
View
|
|
21 chunks |
+37 lines, -40 lines |
0 comments
|
Download
|
|
M |
net/test/spawned_test_server/local_test_server.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
net/test/spawned_test_server/local_test_server_posix.cc
|
View
|
|
3 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
sandbox/linux/services/broker_process_unittest.cc
|
View
|
|
5 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
|
M |
sandbox/linux/services/credentials_unittest.cc
|
View
|
|
4 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
|
M |
sandbox/linux/services/scoped_process_unittest.cc
|
View
|
|
3 chunks |
+6 lines, -5 lines |
0 comments
|
Download
|
|
M |
sandbox/linux/services/yama.cc
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
tools/android/memdump/memdump.cc
|
View
|
|
5 chunks |
+10 lines, -13 lines |
0 comments
|
Download
|
Total messages: 1 (0 generated)
|