Adding missing manifests to gn-built executables

Adding missing manifests to gn-built executables

Many executables are missing embedded manifest files when built with gn.
This causes OS compatibility information to be omitted which can lead
to strange behavior. This adds manifests to two executables.

TBR=reed@google.com
BUG=602505
Committed: https://crrev.com/b3549d99adfdb28aba83dcbdd75ae594398294bd
Cr-Commit-Position: refs/heads/master@{#398087}

[brucedawson, 2016-05-31 18:22:02]

Description was changed from

==========
Adding missing manifests to gn-built executables

Many executables are missing embedded manifest files when built with gn.
This causes OS compatibility information to be ommitted which can lead
to strange behavior. This adds manifests to two executables.

BUG=602505
==========

to

==========
Adding missing manifests to gn-built executables

Many executables are missing embedded manifest files when built with gn.
This causes OS compatibility information to be omitted which can lead
to strange behavior. This adds manifests to two executables.

BUG=602505
==========

[brucedawson, 2016-05-31 18:24:57]

brucedawson@chromium.org changed reviewers:
+ reed@google.com

[brucedawson, 2016-05-31 18:24:58]

Boilerplate change, PTAL

[brucedawson, 2016-06-06 17:21:09]

On 2016/05/31 18:24:58, brucedawson wrote:
> Boilerplate change, PTAL

Ping!

[reed1, 2016-06-06 17:28:01]

reed@google.com changed reviewers:
- reed@google.com

[reed1, 2016-06-06 17:28:02]

Sorry for not commenting. I don't understand anything about missing manifests,
so I can't add any value here. If you don't need any actual review, feel free to
TBR me, but I don't know how to actually comment on this.

[brucedawson, 2016-06-06 17:35:57]

On 2016/06/06 17:28:02, reed1 wrote:
> Sorry for not commenting. I don't understand anything about missing manifests,
> so I can't add any value here. If you don't need any actual review, feel free
to
> TBR me, but I don't know how to actually comment on this.

TBR it is - I'll take responsibility for it being a safe thing to do.

The change basically just tells Windows that these binaries are compatible up to
Windows 10 - so please don't enable compatibility shims.

[brucedawson, 2016-06-06 17:36:16]

Description was changed from

==========
Adding missing manifests to gn-built executables

Many executables are missing embedded manifest files when built with gn.
This causes OS compatibility information to be omitted which can lead
to strange behavior. This adds manifests to two executables.

BUG=602505
==========

to

==========
Adding missing manifests to gn-built executables

Many executables are missing embedded manifest files when built with gn.
This causes OS compatibility information to be omitted which can lead
to strange behavior. This adds manifests to two executables.

TBR=reed@google.com
BUG=602505
==========

[brucedawson, 2016-06-06 17:36:30]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-06-06 17:37:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2021113003/1

[commit-bot: I haz the power, 2016-06-06 19:20:22]

Description was changed from

==========
Adding missing manifests to gn-built executables

Many executables are missing embedded manifest files when built with gn.
This causes OS compatibility information to be omitted which can lead
to strange behavior. This adds manifests to two executables.

TBR=reed@google.com
BUG=602505
==========

to

==========
Adding missing manifests to gn-built executables

Many executables are missing embedded manifest files when built with gn.
This causes OS compatibility information to be omitted which can lead
to strange behavior. This adds manifests to two executables.

TBR=reed@google.com
BUG=602505
==========

[commit-bot: I haz the power, 2016-06-06 19:20:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-06 19:21:52]

Description was changed from

==========
Adding missing manifests to gn-built executables

Many executables are missing embedded manifest files when built with gn.
This causes OS compatibility information to be omitted which can lead
to strange behavior. This adds manifests to two executables.

TBR=reed@google.com
BUG=602505
==========

to

==========
Adding missing manifests to gn-built executables

Many executables are missing embedded manifest files when built with gn.
This causes OS compatibility information to be omitted which can lead
to strange behavior. This adds manifests to two executables.

TBR=reed@google.com
BUG=602505

Committed: https://crrev.com/b3549d99adfdb28aba83dcbdd75ae594398294bd
Cr-Commit-Position: refs/heads/master@{#398087}
==========

[commit-bot: I haz the power, 2016-06-06 19:21:54]

Patchset 1 (id:??) landed as
https://crrev.com/b3549d99adfdb28aba83dcbdd75ae594398294bd
Cr-Commit-Position: refs/heads/master@{#398087}