Statically disallow delete' over heap collection objects.

Statically disallow delete' over heap collection objects.

Explicitly deleting heap-allocated heap collection objects isn't
allowed nor meaningful, the garbage collector handles their lifetimes
precisely. The implementation of 'delete' over these collection objects
delegate to a allocator-trait class's free() method, so by not providing
it for heap collection objects, compilation fails if 'delete' is ever
attempted instantiated & used over these objects.

As MSVC performs method instantiation more eagerly, we're unable to
statically catch such inappropriate uses of 'delete' at compile time.
Rely on a run-time NOTREACHED() instead.

R=
BUG=

Committed: https://crrev.com/47bfa8f726181fcce7265f97727182ee2bdd0283
Cr-Commit-Position: refs/heads/master@{#396788}

[sof, 2016-05-30 18:27:34]

Description was changed from

==========
Catch uses of HeapAllocator::free().

Ideally, this shouldn't be attempted used at run-time.

R=
BUG=
==========

to

==========
Catch uses of HeapAllocator::free().

Ideally, it shouldn't be attempted used at run-time.

R=
BUG=
==========

[sof, 2016-05-30 20:29:08]

Description was changed from

==========
Catch uses of HeapAllocator::free().

Ideally, it shouldn't be attempted used at run-time.

R=
BUG=
==========

to

==========
Disallow 'delete' over heap collection objects at compile-time.

Explicitly deleting heap-allocated heap collection objects isn't
needed nor wanted, the garbage collector handles their lifetimes
precisely. The implementation of 'delete' over these collection
objects delegate to a allocator-trait class's free() method, so
by not providing it for heap collection objects, compilation fails
if 'delete' is ever attempted instantiated & used over these objects.

As MSVC performs method instantiation more eagerly, we're unable to
statically catch such inappropriate uses of 'delete' at compile time.
Rely on a run-time NOTREACHED() instead.

R=
BUG=
==========

[sof, 2016-05-30 20:31:51]

Description was changed from

==========
Disallow 'delete' over heap collection objects at compile-time.

Explicitly deleting heap-allocated heap collection objects isn't
needed nor wanted, the garbage collector handles their lifetimes
precisely. The implementation of 'delete' over these collection
objects delegate to a allocator-trait class's free() method, so
by not providing it for heap collection objects, compilation fails
if 'delete' is ever attempted instantiated & used over these objects.

As MSVC performs method instantiation more eagerly, we're unable to
statically catch such inappropriate uses of 'delete' at compile time.
Rely on a run-time NOTREACHED() instead.

R=
BUG=
==========

to

==========
Statically disallow delete' over heap collection objects.

Explicitly deleting heap-allocated heap collection objects isn't\allowed nor
meaningful, the garbage collector handles their lifetimes precisely.
The implementation of 'delete' over these collection objects delegate
to a allocator-trait class's free() method, so by not providing it for
heap collection objects, compilation fails if 'delete' is ever attempted
instantiated & used over these objects.

As MSVC performs method instantiation more eagerly, we're unable to
statically catch such inappropriate uses of 'delete' at compile time.
Rely on a run-time NOTREACHED() instead.

R=
BUG=
==========

[sof, 2016-05-30 20:32:53]

Description was changed from

==========
Statically disallow delete' over heap collection objects.

Explicitly deleting heap-allocated heap collection objects isn't\allowed nor
meaningful, the garbage collector handles their lifetimes precisely.
The implementation of 'delete' over these collection objects delegate
to a allocator-trait class's free() method, so by not providing it for
heap collection objects, compilation fails if 'delete' is ever attempted
instantiated & used over these objects.

As MSVC performs method instantiation more eagerly, we're unable to
statically catch such inappropriate uses of 'delete' at compile time.
Rely on a run-time NOTREACHED() instead.

R=
BUG=
==========

to

==========
Statically disallow delete' over heap collection objects.

Explicitly deleting heap-allocated heap collection objects isn't
allowed nor meaningful, the garbage collector handles their lifetimes
precisely. The implementation of 'delete' over these collection objects
delegate to a allocator-trait class's free() method, so by not providing
it for heap collection objects, compilation fails if 'delete' is ever
attempted instantiated & used over these objects.

As MSVC performs method instantiation more eagerly, we're unable to
statically catch such inappropriate uses of 'delete' at compile time.
Rely on a run-time NOTREACHED() instead.

R=
BUG=
==========

[sof, 2016-05-30 20:44:47]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2016-05-30 20:44:47]

please take a look.

[haraken, 2016-05-30 23:22:35]

LGTM

[sof, 2016-05-31 05:25:10]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-05-31 05:25:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2021103002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2021103002/60001

[commit-bot: I haz the power, 2016-05-31 05:32:33]

Description was changed from

==========
Statically disallow delete' over heap collection objects.

Explicitly deleting heap-allocated heap collection objects isn't
allowed nor meaningful, the garbage collector handles their lifetimes
precisely. The implementation of 'delete' over these collection objects
delegate to a allocator-trait class's free() method, so by not providing
it for heap collection objects, compilation fails if 'delete' is ever
attempted instantiated & used over these objects.

As MSVC performs method instantiation more eagerly, we're unable to
statically catch such inappropriate uses of 'delete' at compile time.
Rely on a run-time NOTREACHED() instead.

R=
BUG=
==========

to

==========
Statically disallow delete' over heap collection objects.

Explicitly deleting heap-allocated heap collection objects isn't
allowed nor meaningful, the garbage collector handles their lifetimes
precisely. The implementation of 'delete' over these collection objects
delegate to a allocator-trait class's free() method, so by not providing
it for heap collection objects, compilation fails if 'delete' is ever
attempted instantiated & used over these objects.

As MSVC performs method instantiation more eagerly, we're unable to
statically catch such inappropriate uses of 'delete' at compile time.
Rely on a run-time NOTREACHED() instead.

R=
BUG=
==========

[commit-bot: I haz the power, 2016-05-31 05:32:34]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-31 05:33:58]

Description was changed from

==========
Statically disallow delete' over heap collection objects.

Explicitly deleting heap-allocated heap collection objects isn't
allowed nor meaningful, the garbage collector handles their lifetimes
precisely. The implementation of 'delete' over these collection objects
delegate to a allocator-trait class's free() method, so by not providing
it for heap collection objects, compilation fails if 'delete' is ever
attempted instantiated & used over these objects.

As MSVC performs method instantiation more eagerly, we're unable to
statically catch such inappropriate uses of 'delete' at compile time.
Rely on a run-time NOTREACHED() instead.

R=
BUG=
==========

to

==========
Statically disallow delete' over heap collection objects.

Explicitly deleting heap-allocated heap collection objects isn't
allowed nor meaningful, the garbage collector handles their lifetimes
precisely. The implementation of 'delete' over these collection objects
delegate to a allocator-trait class's free() method, so by not providing
it for heap collection objects, compilation fails if 'delete' is ever
attempted instantiated & used over these objects.

As MSVC performs method instantiation more eagerly, we're unable to
statically catch such inappropriate uses of 'delete' at compile time.
Rely on a run-time NOTREACHED() instead.

R=
BUG=

Committed: https://crrev.com/47bfa8f726181fcce7265f97727182ee2bdd0283
Cr-Commit-Position: refs/heads/master@{#396788}
==========

[commit-bot: I haz the power, 2016-05-31 05:33:59]

Patchset 4 (id:??) landed as
https://crrev.com/47bfa8f726181fcce7265f97727182ee2bdd0283
Cr-Commit-Position: refs/heads/master@{#396788}