Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2021053002: [i18n] use intrinsics for conversion instead of wrappers. (Closed)

Created:
4 years, 6 months ago by Yang
Modified:
4 years, 6 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com, jungshik at Google
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[i18n] use intrinsics for conversion instead of wrappers. R=littledan@chromium.org Committed: https://crrev.com/18ba2d1c9127e85df779cc73137148700fa7b92b Cr-Commit-Position: refs/heads/master@{#36598}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -17 lines) Patch
M src/js/i18n.js View 13 chunks +13 lines, -16 lines 0 comments Download
M src/js/v8natives.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Yang
4 years, 6 months ago (2016-05-30 13:00:12 UTC) #1
Dan Ehrenberg
lgtm When are we going to be done with these basic infra/style fixes for Intl?
4 years, 6 months ago (2016-05-30 19:21:34 UTC) #2
Yang
On 2016/05/30 19:21:34, Dan Ehrenberg wrote: > lgtm > > When are we going to ...
4 years, 6 months ago (2016-05-30 19:55:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021053002/1
4 years, 6 months ago (2016-05-30 19:55:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-30 20:24:32 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 20:25:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18ba2d1c9127e85df779cc73137148700fa7b92b
Cr-Commit-Position: refs/heads/master@{#36598}

Powered by Google App Engine
This is Rietveld 408576698