[debugger] add test case for debug-evaluation with promise microtasks.

[debugger] add test case for debug-evaluation with promise microtasks.

R=littledan@chromium.org

Committed: https://crrev.com/2d5c9be331ca4a268329bf187e41bc8927c77501
Cr-Commit-Position: refs/heads/master@{#36711}

[Yang, 2016-05-30 09:58:54]

yangguo@chromium.org changed reviewers:
+ caitpotter88@gmail.com

[Yang, 2016-05-31 11:40:09]

On 2016/05/30 09:58:55, Yang wrote:

ping.

[caitp (gmail), 2016-05-31 11:44:32]

https://codereview.chromium.org/2021013002/diff/1/test/mjsunit/es6/debug-prom...
File test/mjsunit/es6/debug-promises/evaluate-across-microtasks.js (right):

https://codereview.chromium.org/2021013002/diff/1/test/mjsunit/es6/debug-prom...
test/mjsunit/es6/debug-promises/evaluate-across-microtasks.js:29: try {
I think we hit this because d8 won't die if the microtask queue is non-empty,
right? But it's not really asserted that this assertion is ever reached, so it's
possible it could fail silently.

Is there a way we can ensure (and assert) that this line is reached before
quitting?

https://codereview.chromium.org/2021013002/diff/1/test/mjsunit/es6/debug-prom...
test/mjsunit/es6/debug-promises/evaluate-across-microtasks.js:51:
print("failure");
if we fail here, it would be helpful to print the exception

[Yang, 2016-06-01 08:55:22]

https://codereview.chromium.org/2021013002/diff/1/test/mjsunit/es6/debug-prom...
File test/mjsunit/es6/debug-promises/evaluate-across-microtasks.js (right):

https://codereview.chromium.org/2021013002/diff/1/test/mjsunit/es6/debug-prom...
test/mjsunit/es6/debug-promises/evaluate-across-microtasks.js:29: try {
On 2016/05/31 11:44:32, caitp wrote:
> I think we hit this because d8 won't die if the microtask queue is non-empty,
> right? But it's not really asserted that this assertion is ever reached, so
it's
> possible it could fail silently.
> 
> Is there a way we can ensure (and assert) that this line is reached before
> quitting?

Good point. I haven't found a good way to do this than adding a repeating micro
tasks that polls whether we hit this line.

https://codereview.chromium.org/2021013002/diff/1/test/mjsunit/es6/debug-prom...
test/mjsunit/es6/debug-promises/evaluate-across-microtasks.js:51:
print("failure");
On 2016/05/31 11:44:32, caitp wrote:
> if we fail here, it would be helpful to print the exception

Done.

[Dan Ehrenberg, 2016-06-01 10:38:13]

https://codereview.chromium.org/2021013002/diff/1/test/mjsunit/es6/debug-prom...
File test/mjsunit/es6/debug-promises/evaluate-across-microtasks.js (right):

https://codereview.chromium.org/2021013002/diff/1/test/mjsunit/es6/debug-prom...
test/mjsunit/es6/debug-promises/evaluate-across-microtasks.js:29: try {
On 2016/06/01 at 08:55:21, Yang wrote:
> On 2016/05/31 11:44:32, caitp wrote:
> > I think we hit this because d8 won't die if the microtask queue is
non-empty,
> > right? But it's not really asserted that this assertion is ever reached, so
it's
> > possible it could fail silently.
> > 
> > Is there a way we can ensure (and assert) that this line is reached before
> > quitting?
> 
> Good point. I haven't found a good way to do this than adding a repeating
micro tasks that polls whether we hit this line.

Maybe you could use the new %RunMicrotasks call, which should keep going until
the microtask queue is exhausted.

[Dan Ehrenberg, 2016-06-01 10:43:07]

lgtm

[Yang, 2016-06-01 12:46:34]

On 2016/06/01 10:43:07, Dan Ehrenberg wrote:
> lgtm

Good point. Using %RunMicrotasks makes things a lot easier.

[Dan Ehrenberg, 2016-06-01 13:18:47]

lgtm

[Yang, 2016-06-03 11:40:42]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-06-03 11:40:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2021013002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2021013002/40001

[commit-bot: I haz the power, 2016-06-03 12:07:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-03 12:07:49]

Description was changed from

==========
[debugger] add test case for debug-evaluation with promise microtasks.

R=littledan@chromium.org
==========

to

==========
[debugger] add test case for debug-evaluation with promise microtasks.

R=littledan@chromium.org

Committed: https://crrev.com/2d5c9be331ca4a268329bf187e41bc8927c77501
Cr-Commit-Position: refs/heads/master@{#36711}
==========

[commit-bot: I haz the power, 2016-06-03 12:07:50]

Patchset 3 (id:??) landed as
https://crrev.com/2d5c9be331ca4a268329bf187e41bc8927c77501
Cr-Commit-Position: refs/heads/master@{#36711}