content/browser/renderer_host/render_widget_host_view_android.h - Issue 2021003002: LockCompositingSurface to make sure frame is not evicted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.h

Issue 2021003002: LockCompositingSurface to make sure frame is not evicted. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/compositor/tab_content_manager.cc ('k') | content/browser/renderer_host/render_widget_host_view_android.cc » ('j') | content/browser/renderer_host/render_widget_host_view_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.h

diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h

index ce75be559d086d904b9915902ed5a0807e9e401e..94daa57abc3b5e3290eaa1e9aff9b873a0764ad7 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.h

+++ b/content/browser/renderer_host/render_widget_host_view_android.h

@@ -73,7 +73,8 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid

public DelegatedFrameEvictorClient,

public StylusTextSelectorClient,

public ui::TouchSelectionControllerClient,

- public content::ContentViewCoreImplObserver {

+ public content::ContentViewCoreImplObserver,

+ public base::SupportsWeakPtr<RenderWidgetHostViewAndroid> {

no sievers 2016/06/01 22:32:06 There is already a |weak_ptr_factory_| in this cla

sivag 2016/06/02 14:34:50 Done.

public:

RenderWidgetHostViewAndroid(RenderWidgetHostImpl* widget,

ContentViewCoreImpl* content_view_core);

@@ -284,6 +285,7 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid

// Called after async screenshot task completes. Scales and crops the result

// of the copy.

static void PrepareTextureCopyOutputResult(

+ base::WeakPtr<RenderWidgetHostViewAndroid> rwhva,

const gfx::Size& dst_size_in_pixel,

SkColorType color_type,

const base::TimeTicks& start_time,