Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2021003: Simplify the Windows <keygen> implementation by making... (Closed)

Created:
10 years, 7 months ago by wtc
Modified:
9 years, 7 months ago
Reviewers:
rsleevi-old
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Simplify the Windows <keygen> implementation by making better use of CryptoAPI. Contributed by Ryan Sleevi <ryan.sleevi@gmail.com>;. Original review URL: http://codereview.chromium.org/1934001 R=wtc BUG=148 TEST=Keygenhandler.SmokeTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46630

Patch Set 1 #

Patch Set 2 : Add definition of PublicKeyAndChallenge and rename a variable pkac. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -104 lines) Patch
M net/base/keygen_handler_win.cc View 1 4 chunks +48 lines, -104 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
wtc
10 years, 7 months ago (2010-05-06 20:20:08 UTC) #1
Ryan, I will check in your patch with these changes.

Powered by Google App Engine
This is Rietveld 408576698