Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2020993004: Implement TransferableResource StructTraits (Closed)

Created:
4 years, 6 months ago by Fady Samuel
Modified:
4 years, 6 months ago
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nona+watch_chromium.org, shuchen+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, James Su, ben+mojo_chromium.org, darin (slow to review), yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement TransferableResource StructTraits This CL also moves out the dependency on skia resource_format.h to resource_format_utils. This was to avoid adding skia as a public dependency from the TransferableResource StructTraits. BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/6ee49c47ef4aec355eb3f23064a8de8ec4245aed Cr-Commit-Position: refs/heads/master@{#397105}

Patch Set 1 #

Patch Set 2 : Removed unnecessary changes #

Patch Set 3 : Diff against mailbox cl #

Patch Set 4 : Diff against master for testing #

Patch Set 5 : Rebased #

Patch Set 6 : Fixed DEPS file #

Patch Set 7 : Fix gyp build #

Patch Set 8 : Diff against previous patch + Cleanup unit test #

Patch Set 9 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -157 lines) Patch
M cc/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M cc/cc.gyp View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M cc/cc_tests.gyp View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M cc/ipc/BUILD.gn View 1 2 3 4 5 6 7 3 chunks +4 lines, -1 line 0 comments Download
M cc/ipc/struct_traits_unittest.cc View 1 2 3 4 5 6 7 2 chunks +65 lines, -0 lines 0 comments Download
M cc/ipc/traits_test_service.mojom View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
A cc/ipc/transferable_resource.mojom View 1 chunk +31 lines, -0 lines 0 comments Download
A cc/ipc/transferable_resource.typemap View 1 chunk +15 lines, -0 lines 0 comments Download
A cc/ipc/transferable_resource_struct_traits.h View 1 chunk +76 lines, -0 lines 0 comments Download
M cc/ipc/typemaps.gni View 2 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M cc/raster/raster_buffer_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/resources/resource_format.h View 2 chunks +0 lines, -3 lines 0 comments Download
M cc/resources/resource_format.cc View 1 chunk +0 lines, -23 lines 0 comments Download
A cc/resources/resource_format_utils.h View 1 chunk +17 lines, -0 lines 0 comments Download
A cc/resources/resource_format_utils.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M cc/tiles/gpu_image_decode_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/tiles/software_image_decode_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/bitmap_uploader/bitmap_uploader.cc View 2 4 5 6 7 2 chunks +11 lines, -12 lines 0 comments Download
M components/mus/public/cpp/surfaces/surfaces_type_converters.h View 2 4 5 6 7 1 chunk +0 lines, -13 lines 0 comments Download
M components/mus/public/cpp/surfaces/surfaces_type_converters.cc View 2 4 5 6 7 5 chunks +2 lines, -38 lines 0 comments Download
M components/mus/public/cpp/surfaces/tests/surface_unittest.cc View 2 4 5 6 7 3 chunks +0 lines, -39 lines 0 comments Download
M components/mus/public/interfaces/compositor_frame.mojom View 2 4 5 6 7 2 chunks +2 lines, -28 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 32 (17 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020993004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020993004/60001
4 years, 6 months ago (2016-05-31 01:05:49 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/191936)
4 years, 6 months ago (2016-05-31 01:13:20 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020993004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020993004/80001
4 years, 6 months ago (2016-05-31 01:46:18 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/191954)
4 years, 6 months ago (2016-05-31 01:58:08 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020993004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020993004/100001
4 years, 6 months ago (2016-05-31 03:10:41 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/220469)
4 years, 6 months ago (2016-05-31 03:28:37 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020993004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020993004/120001
4 years, 6 months ago (2016-05-31 04:00:21 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-31 05:05:48 UTC) #18
Fady Samuel
+ben@ for mus +piman@ for cc +tsepez@ for ipc
4 years, 6 months ago (2016-05-31 17:53:20 UTC) #21
Tom Sepez
IPC lgtm
4 years, 6 months ago (2016-05-31 18:00:01 UTC) #23
piman
lgtm
4 years, 6 months ago (2016-05-31 19:12:23 UTC) #24
Ben Goodger (Google)
non-cc bits lgtm
4 years, 6 months ago (2016-05-31 19:26:42 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020993004/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020993004/160001
4 years, 6 months ago (2016-06-01 09:25:31 UTC) #28
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years, 6 months ago (2016-06-01 11:17:07 UTC) #30
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 11:18:17 UTC) #32
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/6ee49c47ef4aec355eb3f23064a8de8ec4245aed
Cr-Commit-Position: refs/heads/master@{#397105}

Powered by Google App Engine
This is Rietveld 408576698