Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2020993003:
Make GPU FYI Clang builder mirror the main. (Closed)
|
Created:
4 years, 6 months ago by Jamie Madill Modified:
4 years, 6 months ago CC:
chromium-reviews, Corentin Wallez Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake GPU FYI Clang builder mirror the main.
This will shift it to using a GN config, without x64/x86 specified
explicitly. It uses the exact same mixins as the 'win_clang_debug_bot'
mixin, except with the additional GPU-specific configs as well.
BUG=angleproject:1311
Committed: https://crrev.com/9fb36edf898e0b24f35fdcd39de9a94012a7326a
Cr-Commit-Position: refs/heads/master@{#396958}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Fix naming #Messages
Total messages: 16 (7 generated)
Description was changed from ========== Make GPU FYI Clang builder mirror the main. This will shift it to using a GN config, without x64/x86 specified explicitly. It uses the exact same mixins as the 'win_clang_debug_bot' mixin, except with the additional GPU-specific configs as well. BUG=angleproject:1311 ========== to ========== Make GPU FYI Clang builder mirror the main. This will shift it to using a GN config, without x64/x86 specified explicitly. It uses the exact same mixins as the 'win_clang_debug_bot' mixin, except with the additional GPU-specific configs as well. BUG=angleproject:1311 ==========
jmadill@chromium.org changed reviewers: + dpranke@chromium.org, kbr@chromium.org
Ken, Dirk, PTAL. Might have to land at the same time as the build side change.
lgtm
The CQ bit was checked by jmadill@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020993003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020993003/1
lgtm with comments https://codereview.chromium.org/2020993003/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2020993003/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:1596: 'swarming_gpu_fyi_tests_gyp_clang_debug_bot': [ This is misnamed now -- it's using gn below rather than gyp. I think this should be renamed "swarming_gpu_fyi_win_clang_debug_bot" or similar, and just include the win_clang_debug_bot mixin, plus "swarming", "gpu_tests" and "internal_gles2_conform_tests". Then there's less likelihood of it changing from how the main Clang bots work in the future.
On 2016/05/31 20:31:08, Ken Russell wrote: > lgtm with comments > > https://codereview.chromium.org/2020993003/diff/1/tools/mb/mb_config.pyl > File tools/mb/mb_config.pyl (right): > > https://codereview.chromium.org/2020993003/diff/1/tools/mb/mb_config.pyl#newc... > tools/mb/mb_config.pyl:1596: 'swarming_gpu_fyi_tests_gyp_clang_debug_bot': [ > This is misnamed now -- it's using gn below rather than gyp. > > I think this should be renamed "swarming_gpu_fyi_win_clang_debug_bot" or > similar, and just include the win_clang_debug_bot mixin, plus "swarming", > "gpu_tests" and "internal_gles2_conform_tests". Then there's less likelihood of > it changing from how the main Clang bots work in the future. Changed the name, PTAL. Before I uploaded I had tried using the win_clang_debug_bot, but I think win_clang_debug_bot is defined in the same scope as the gpu fyi clang, so presubmit complained there was an error. I didn't feel comfortable refactoring this file so just included the same mixins. I can give it a go if necessary, but bots are currently broken temporarily.
lgtm again - you don't need to wait for a re-lgtm ever unless one is specifically requested.
The CQ bit was checked by jmadill@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2020993003/#ps20001 (title: "Fix naming")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020993003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020993003/20001
Message was sent while issue was closed.
Description was changed from ========== Make GPU FYI Clang builder mirror the main. This will shift it to using a GN config, without x64/x86 specified explicitly. It uses the exact same mixins as the 'win_clang_debug_bot' mixin, except with the additional GPU-specific configs as well. BUG=angleproject:1311 ========== to ========== Make GPU FYI Clang builder mirror the main. This will shift it to using a GN config, without x64/x86 specified explicitly. It uses the exact same mixins as the 'win_clang_debug_bot' mixin, except with the additional GPU-specific configs as well. BUG=angleproject:1311 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Make GPU FYI Clang builder mirror the main. This will shift it to using a GN config, without x64/x86 specified explicitly. It uses the exact same mixins as the 'win_clang_debug_bot' mixin, except with the additional GPU-specific configs as well. BUG=angleproject:1311 ========== to ========== Make GPU FYI Clang builder mirror the main. This will shift it to using a GN config, without x64/x86 specified explicitly. It uses the exact same mixins as the 'win_clang_debug_bot' mixin, except with the additional GPU-specific configs as well. BUG=angleproject:1311 Committed: https://crrev.com/9fb36edf898e0b24f35fdcd39de9a94012a7326a Cr-Commit-Position: refs/heads/master@{#396958} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9fb36edf898e0b24f35fdcd39de9a94012a7326a Cr-Commit-Position: refs/heads/master@{#396958} |
