Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodController.h

Issue 2020973002: Reland: Fix setComposingText with empty text when newCursorPosition != 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reland. Add a parameter. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/InputMethodController.h
diff --git a/third_party/WebKit/Source/core/editing/InputMethodController.h b/third_party/WebKit/Source/core/editing/InputMethodController.h
index bf7e152cad58c360be8cf1e35fa5a88e6c2217de..2a36cd448c04744b1a4cd951af5f87b778700fef 100644
--- a/third_party/WebKit/Source/core/editing/InputMethodController.h
+++ b/third_party/WebKit/Source/core/editing/InputMethodController.h
@@ -30,6 +30,7 @@
#include "core/dom/Range.h"
#include "core/editing/CompositionUnderline.h"
#include "core/editing/EphemeralRange.h"
+#include "core/editing/FrameSelection.h"
#include "core/editing/PlainTextRange.h"
#include "platform/heap/Handle.h"
#include "wtf/Vector.h"
@@ -76,8 +77,9 @@ public:
PlainTextRange getSelectionOffsets() const;
// Returns true if setting selection to specified offsets, otherwise false.
- bool setEditableSelectionOffsets(const PlainTextRange&);
+ bool setEditableSelectionOffsets(const PlainTextRange&, FrameSelection::SetSelectionOptions = FrameSelection::CloseTyping);
void extendSelectionAndDelete(int before, int after);
+ PlainTextRange createRangeForSelection(int start, int end, size_t textLength) const;
private:
class SelectionOffsetsScope {
@@ -108,7 +110,7 @@ private:
String composingText() const;
void selectComposition() const;
- bool setSelectionOffsets(const PlainTextRange&);
+ bool setSelectionOffsets(const PlainTextRange&, FrameSelection::SetSelectionOptions = FrameSelection::CloseTyping);
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698