Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

Issue 2020973002: Reland: Fix setComposingText with empty text when newCursorPosition != 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use a different method to get the right boundary Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp b/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
index b176244dce8033ea84b758f52b67d042185fbfce..13e0afa6e9fb635cafe624a15c944540aee7a79f 100644
--- a/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
+++ b/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
@@ -348,6 +348,36 @@ TEST_F(InputMethodControllerTest, SetCompositionForContentEditableWithDifferentN
EXPECT_EQ(24u, controller().getSelectionOffsets().end());
}
+TEST_F(InputMethodControllerTest, SetCompositionWithEmptyText)
+{
+ Element* div = insertHTMLElement(
+ "<div id='sample' contenteditable='true'>hello</div>",
+ "sample");
+
+ controller().setEditableSelectionOffsets(PlainTextRange(2, 2));
+ EXPECT_STREQ("hello", div->innerText().utf8().data());
+ EXPECT_EQ(2u, controller().getSelectionOffsets().start());
+ EXPECT_EQ(2u, controller().getSelectionOffsets().end());
+
+ Vector<CompositionUnderline> underlines0;
+ underlines0.append(CompositionUnderline(0, 0, Color(255, 0, 0), false, 0));
+ Vector<CompositionUnderline> underlines2;
+ underlines2.append(CompositionUnderline(0, 2, Color(255, 0, 0), false, 0));
+
+ controller().setComposition("AB", underlines2, 2, 2);
+ // With previous composition.
+ controller().setComposition("", underlines0, 2, 2);
+ EXPECT_STREQ("hello", div->innerText().utf8().data());
+ EXPECT_EQ(4u, controller().getSelectionOffsets().start());
+ EXPECT_EQ(4u, controller().getSelectionOffsets().end());
+
+ // Without previous composition.
+ controller().setComposition("", underlines0, -1, -1);
+ EXPECT_STREQ("hello", div->innerText().utf8().data());
+ EXPECT_EQ(3u, controller().getSelectionOffsets().start());
+ EXPECT_EQ(3u, controller().getSelectionOffsets().end());
+}
+
TEST_F(InputMethodControllerTest, CompositionFireBeforeInput)
{
document().settings()->setScriptEnabled(true);

Powered by Google App Engine
This is Rietveld 408576698