Chromium Code Reviews

Side by Side Diff: third_party/WebKit/Source/core/editing/InputMethodController.h

Issue 2020973002: Reland: Fix setComposingText with empty text when newCursorPosition != 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use a different method to get the right boundary Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff |
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 61 matching lines...)
72 Range* compositionRange() const; 72 Range* compositionRange() const;
73 73
74 void clear(); 74 void clear();
75 void documentDetached(); 75 void documentDetached();
76 76
77 PlainTextRange getSelectionOffsets() const; 77 PlainTextRange getSelectionOffsets() const;
78 // Returns true if setting selection to specified offsets, otherwise false. 78 // Returns true if setting selection to specified offsets, otherwise false.
79 bool setEditableSelectionOffsets(const PlainTextRange&); 79 bool setEditableSelectionOffsets(const PlainTextRange&);
80 void extendSelectionAndDelete(int before, int after); 80 void extendSelectionAndDelete(int before, int after);
81 81
82 PlainTextRange createRangeForSelection(int start, int end, size_t textLength );
83
82 private: 84 private:
83 class SelectionOffsetsScope { 85 class SelectionOffsetsScope {
84 WTF_MAKE_NONCOPYABLE(SelectionOffsetsScope); 86 WTF_MAKE_NONCOPYABLE(SelectionOffsetsScope);
85 STACK_ALLOCATED(); 87 STACK_ALLOCATED();
86 public: 88 public:
87 explicit SelectionOffsetsScope(InputMethodController*); 89 explicit SelectionOffsetsScope(InputMethodController*);
88 ~SelectionOffsetsScope(); 90 ~SelectionOffsetsScope();
89 private: 91 private:
90 Member<InputMethodController> m_inputMethodController; 92 Member<InputMethodController> m_inputMethodController;
91 const PlainTextRange m_offsets; 93 const PlainTextRange m_offsets;
(...skipping 15 matching lines...)
107 } 109 }
108 110
109 String composingText() const; 111 String composingText() const;
110 void selectComposition() const; 112 void selectComposition() const;
111 bool setSelectionOffsets(const PlainTextRange&); 113 bool setSelectionOffsets(const PlainTextRange&);
112 }; 114 };
113 115
114 } // namespace blink 116 } // namespace blink
115 117
116 #endif // InputMethodController_h 118 #endif // InputMethodController_h
OLDNEW

Powered by Google App Engine