chrome/browser/resources/settings/settings_ui/settings_ui.html - Issue 2020963002: MD History: Add responsive layout which hides the sidebar in thin windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_ui/settings_ui.html

Issue 2020963002: MD History: Add responsive layout which hides the sidebar in thin windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix review comments and RTL Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/icons.html ('k') | ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html » ('j') | ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_ui/settings_ui.html

diff --git a/chrome/browser/resources/settings/settings_ui/settings_ui.html b/chrome/browser/resources/settings/settings_ui/settings_ui.html

index 22f699e2ec3901b58a43473e2142e5266ee6d95c..86a43f3fef39eadc88d1cb9bab5932d8c06af15d 100644

--- a/chrome/browser/resources/settings/settings_ui/settings_ui.html

+++ b/chrome/browser/resources/settings/settings_ui/settings_ui.html

@@ -63,7 +63,6 @@

cr-toolbar {

@apply(--layout-center);

- --side-bar-width: 256px;

background-color: var(--settings-title-bar-background-color);

color: white;

min-height: 56px;

@@ -91,9 +90,7 @@

addressed -->

<cr-toolbar page-name="$i18n{settings}"

clear-label="$i18n{clearSearch}" search-prompt="$i18n{searchPrompt}

- (coming soon!)">

- <paper-icon-button icon="settings:menu" on-tap="onMenuButtonTap_">

- </paper-icon-button>

+ (coming soon!)" on-cr-menu-tap="onMenuButtonTap_">

</cr-toolbar>

<app-drawer swipe-open>

<div class="drawer-header">$i18n{settings}</div>